Skip to content

Feature/custom images#1389

Merged
herpaderpaldent merged 8 commits into4.xfrom
feature/custom_images
Oct 30, 2023
Merged

Feature/custom images#1389
herpaderpaldent merged 8 commits into4.xfrom
feature/custom_images

Conversation

@herpaderpaldent
Copy link
Copy Markdown
Contributor

This allows users to define custom images for icon and logo.

simply add the logo and the icon into the /src/public/img/ folder and then add the either or both of .env variables.

LOGO_PATH=img/logo.svg
ICON_PATH=img/icon.svg

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Oct 15, 2023

PR Summary

  • Addition of Web Images Configuration File
    A new file called web.images.php has been added. This file will store various image paths, including the paths for the logo and icon.

  • Updates in Code
    There is a vast set of updates throughout the various files, with the aim to refine and optimize the code. The specific syntax <title> and <style> have been eliminated in numerous files and replaced with <AppHead> component which helps to structure our codes better.

  • Addition of <AppHead> Component
    A new component named AppHead.vue has been introduced to improve the application's performance. This component is designed to work with the appTitle and has been used in different sections of the application.

  • Removal from Title Method Mixin
    The title method mixin from app.js has been removed to clean up the code.

  • Enhancements to Icon
    The <link rel="icon" href="/img/seat_plus_logo.svg"> tag has been removed from app.blade.php as part of the updates in icon settings.

  • Updates to Query Builder & Shared Method
    Notable updates have been made to enhance the functionalities in files like GetAffiliatedCorporationsController.php and HandleInertiaRequests.php.

  • Merge Configurations Method Updated
    WebServiceProvider.php has been updated to merge configurations with web.images, it gives us the ability to manage our application configuration in a better way.

  • Test Corrections
    There have been corrections to tests files like HelperControllerTest.php and CheckRequiredScopesMiddlewareTest.php to improve their performance and accuracy.

These changes will help in improving the overall performance and readability of the code, enhancing the user experience and developer's work efficiency, and optimizing the application’s overall performance.

@herpaderpaldent herpaderpaldent merged commit d77c1b4 into 4.x Oct 30, 2023
@herpaderpaldent herpaderpaldent deleted the feature/custom_images branch October 30, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant