Skip to content

import correct heroicon modul path#1404

Merged
herpaderpaldent merged 1 commit into4.xfrom
fix/vite-build
Nov 26, 2023
Merged

import correct heroicon modul path#1404
herpaderpaldent merged 1 commit into4.xfrom
fix/vite-build

Conversation

@herpaderpaldent
Copy link
Copy Markdown
Contributor

@herpaderpaldent herpaderpaldent commented Nov 26, 2023

This fixes a bug where the prod build failed:

[vite]: Rollup failed to resolve import "@heroicons/vue/20/solid/esm" from "/Users/user/PhpstormProjects/base-app/src/resources/js/Shared/Components/Mails/MobileMailList.vue".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
error during build:
Error: [vite]: Rollup failed to resolve import "@heroicons/vue/20/solid/esm" from "/Users/user/PhpstormProjects/base-app/src/resources/js/Shared/Components/Mails/MobileMailList.vue".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Nov 26, 2023

PR Summary

  • Enhancement of MobileMailList Component
    A new visual element has been added to the MobileMailList.vue component to enrich the user interface, by importing ChevronUpIcon from the solid icons library of Heroicons.
    This change aims to improve user interaction and accessibility on our mobile mail list feature.

@herpaderpaldent herpaderpaldent merged commit e5ad974 into 4.x Nov 26, 2023
@herpaderpaldent herpaderpaldent deleted the fix/vite-build branch November 26, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant