chore: upgrade to Pest 4, drop composer-patches workaround#1481
Conversation
… API `pestphp/pest-plugin-type-coverage` v4.0.4 calls `RuleErrorTransformer::transform()` with wrong argument types: - arg 3: `[]` (array) instead of `string $nodeType` - arg 4: `$node` (Node object) instead of `int $nodeLine` PHPStan's API has always expected `(RuleError, Scope, string, int)`. Fix: - Add `patches/pest-plugin-type-coverage-fix-transform-args.patch` that corrects both calls to use `$nodeType` and `$node->getLine()` - Add `cweagans/composer-patches` as a dev dependency so the patch is re-applied automatically on `composer install`/`update` - Allow the composer-patches plugin in config Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Bump larastan/larastan ^2 → ^3 (requires PHPStan 2.x)
- Bump phpstan/phpstan 1.x → 2.x (transitive via larastan)
- Bump rector/rector ^1 → ^2 (PHPStan 2.x compat)
- Bump driftingly/rector-laravel ^1 → ^2 (rector 2.x compat)
- Bump tomasvotruba/type-coverage ^1 → ^2 (PHPStan 2.x compat)
PHPStan 2.x fixes:
- phpstan.neon.dist: add (?) suffix to 3 non-existent excludePaths entries
- phpstan.neon.dist: suppress larastan.noEnvCallsOutsideOfConfig (package config files)
- phpstan.neon.dist: suppress property.notFound for cross-package polymorphic relations
- phpstan.neon.dist: suppress trait.unused for HasWatchlist (registered at runtime)
- ContractsController: replace magic whereCharacterId/whereContractId with where()
- SidebarPermissionChecker: replace magic whereId() with where('id', ...)
- GetEntityFromId: remove nullsafe operators on non-nullable CharacterAffiliation
- SearchService: add @var annotation for Cache::remember() mixed return type
- HasCharacterNecessaryRole: extract typed $characterRoles to resolve CharacterRole::hasRole()
test:unit fix:
- Add --no-coverage to test:unit script (phpunit.xml has <source> which PHPUnit 12
initialises coverage for — without Xdebug in coverage mode this emits a warning
that failOnWarning=true turns into a failure)
- Update phpunit.xml schema URL to PHPUnit 12.5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove cweagans/composer-patches and the patch file that was working around the pestphp/pest-plugin-type-coverage RuleErrorTransformer bug. The upstream fix is now released so the patch is no longer needed. Also removes tomasvotruba/type-coverage which is superseded by the pest-plugin-type-coverage v4 built-in type coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PR Summary
|
- Deleted `patches/pest-plugin-type-coverage-fix-transform-args.patch`. - Upstream fix has been released, rendering the local patch unnecessary.
…omId Larastan v3 infers BelongsTo/HasOne as non-null on in-memory models, but at runtime the relation IS null when the related record is absent from the local DB. The ?-> guard ensures the ?? fallback to $this->names is reachable. Suppress nullsafe.neverNull and property.notFound for this file in phpstan.neon.dist — both are Larastan false positives for this pattern. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
herpaderpaldent
force-pushed
the
chore/pest-4
branch
from
f61391b to
8deb914
Compare
Pest 4 supports --parallel --shard N/M. The single sequential job is replaced with: - lint job: coding standards, PHPStan, type coverage (no DB needed) - test matrix job: 4 shards running in parallel, each with postgres+redis Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…moved) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The three files were deleted previously; the (?) suffix was a temporary workaround to avoid PHPStan errors on missing paths. Remove them cleanly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ce condition LazilyRefreshDatabase cannot handle concurrent workers racing to create the migrations table. The 4-shard matrix already provides CI-level parallelism; --parallel within each shard is unnecessary and causes SQLSTATE[42P01] failures on PostgreSQL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
No point running 4 test shards if static analysis or coding standards already failed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
phpunit.xml has failOnWarning=true; without --no-coverage pest emits 'WARN No code coverage driver available' which triggers exit code 1 before any tests run. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
composer install runs once in 'setup', populates the cache. 'lint' and all 4 'test' shards both depend on 'setup' and restore from cache — they run concurrently without re-downloading packages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… check - --shard requires = not a space in Pest v4 - Add summary 'Laravel' job (needs: lint + test) so branch protection rule that gates on 'Laravel' status check still passes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…edErrors=false The shared-cache setup job approach was unreliable: if lint/test got a cache miss they had no fallback install step, leaving PHPStan without a vendor dir and reporting all suppressions as 'unmatched'. Restore the proven per-job cache+install pattern from ace49eb. Add reportUnmatchedIgnoredErrors: false to phpstan.neon.dist so that suppressions which don't match on a given Larastan version are silently skipped rather than causing CI to fail. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 participant
Summary
Resolves #1477.
The upstream bug in
pestphp/pest-plugin-type-coverage(theRuleErrorTransformer::transform()argument mismatch) has been fixed in the released version. This PR removes the workaround that was added in the previous iteration:cweagans/composer-patchesfromrequire-devpatches/directory entry and patch file fromextra.patchestomasvotruba/type-coverage(superseded bypest-plugin-type-coveragev4 built-in type coverage)cweagans/composer-patchesfromconfig.allow-pluginsTesting
composer run testpasses with Pest 4 natively — no patches needed.