Support area places on channels#145
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for assigning general admission area places (area_places / areaPlaces) to event channels, extending the Python client’s channel APIs and domain model so these values can be sent to and read back from the Seatsio API.
Changes:
- Add
area_placessupport to channel operations: add channel, update channel, add/remove objects on a channel. - Update request serialization and the
Channeldomain model to carry and serializeareaPlaces. - Add test coverage for
area_placeson add/update/add_objects/remove_objects channel flows.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/events/channels/testUpdateChannel.py | Adds a test verifying updating area_places on an existing channel. |
| tests/events/channels/testRemoveObjectsFromChannel.py | Adds a test verifying removing area_places from a channel via remove_objects. |
| tests/events/channels/testAddObjectsToChannel.py | Adds a test verifying adding area_places via add_objects. |
| tests/events/channels/testAddChannel.py | Adds a test verifying creating a channel with area_places. |
| seatsio/events/channelsRequests.py | Extends request payloads to include areaPlaces; updates replace-channels serialization. |
| seatsio/events/channelsClient.py | Extends client method signatures to accept area_places and forwards it into requests. |
| seatsio/events/channelProperties.py | Extends ChannelProperties with area_places mapped to areaPlaces. |
| seatsio/domain.py | Extends Channel model with area_places and adds JSON serialization for replace-channels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def create(cls, param): | ||
| if param is not None: | ||
| return Channel(param.get('name'), param.get('color'), param.get('index'), param.get('key'), param.get('objects')) | ||
| return Channel(param.get('name'), param.get('color'), param.get('index'), param.get('key'), param.get('objects'), param.get('areaPlaces') or None) |
Comment on lines
28
to
32
| if categories is not None: | ||
| request["categories"] = categories | ||
| if channels is not None: | ||
| request['channels'] = channels | ||
| request['channels'] = [c.to_json() for c in channels] | ||
| if for_sale_config is not None: |
bverbeken
approved these changes
May 21, 2026
sdivelbiss
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.