Filenames in HTML report are not escaped#1212
Closed
edorian wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1212 +/- ##
============================================
+ Coverage 82.83% 83.05% +0.21%
- Complexity 1574 1575 +1
============================================
Files 113 113
Lines 5326 5329 +3
============================================
+ Hits 4412 4426 +14
+ Misses 914 903 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sebastianbergmann
changed the title
sebastianbergmann
added a commit
that referenced
this pull request
Jun 1, 2026
sebastianbergmann
added a commit
that referenced
this pull request
Jun 1, 2026
* 14.1: Update tools Backport #1212 Update dependency phpstan/phpstan to ^2.2.1 Update dependency phpunit/phpunit to ^12.5.28 Update dependency tomasvotruba/type-coverage to ^2.2.1 Update dependency phpstan/phpstan to ^2.1.56 Update dependency sebastian/environment to ^8.1.2 Update dependency phpunit/phpunit to ^12.5.27 Update dependency phpunit/phpunit to ^12.5.26 Update dependency sebastian/environment to ^8.1.1 Update dependency sebastian/lines-of-code to ^4.0.1 Update github-actions Update dependency phpstan/phpstan to ^2.1.55 Update codecov/codecov-action digest to e79a696
Owner
|
I backported the changes that apply to |
sebastianbergmann
added a commit
that referenced
this pull request
Jun 1, 2026
Route class, trait, function, and method names in the per-file HTML report through htmlspecialchars(), consistent with the filename escaping added in #1212. These names originate from PHP-Parser identifiers and cannot contain HTML metacharacters today, so this is defense-in-depth that keeps the renderer's escaping uniform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've recently been playing around with oddly named files as part of a testing project, and while using the code coverage report, I’ve noticed that they sometimes break the layout.
The fix feels somewhat minimal, so hopefully this is the right place and a sensible change.