Refactor PHPUnit\Util\Configuration#3914
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3914 +/- ##
============================================
- Coverage 83.72% 81.52% -2.21%
- Complexity 3856 3991 +135
============================================
Files 151 171 +20
Lines 10218 10840 +622
============================================
+ Hits 8555 8837 +282
- Misses 1663 2003 +340
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3914 +/- ##
============================================
- Coverage 85.56% 82.76% -2.81%
- Complexity 3826 4117 +291
============================================
Files 157 216 +59
Lines 9678 10531 +853
============================================
+ Hits 8281 8716 +435
- Misses 1397 1815 +418
Continue to review full report at Codecov.
|
f681576 to
b00e2eb
Compare
3dda0f7 to
3f245f6
Compare
4faaeb7 to
0556a8a
Compare
e779575 to
12e9d4c
Compare
e19c6eb to
b5fe850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods of
PHPUnit\Util\Configurationcurrently return arrays. Value Objects should be used instead of these arrays.Progress
getExtensionConfiguration()getFilterConfiguration()getGroupConfiguration()getTestdoxGroupConfiguration()getListenerConfiguration()getLoggingConfiguration()getPHPConfiguration()getPHPUnitConfiguration()getTestSuiteConfiguration()PHPUnit\Util\Configurationto separate object