Skip to content

Refactor PHPUnit\Util\Configuration#3914

Merged
sebastianbergmann merged 51 commits into
masterfrom
refactor/configuration
Jan 24, 2020
Merged

Refactor PHPUnit\Util\Configuration#3914
sebastianbergmann merged 51 commits into
masterfrom
refactor/configuration

Conversation

@sebastianbergmann
Copy link
Copy Markdown
Owner

@sebastianbergmann sebastianbergmann commented Oct 29, 2019

The methods of PHPUnit\Util\Configuration currently return arrays. Value Objects should be used instead of these arrays.

Progress

  • getExtensionConfiguration()
  • getFilterConfiguration()
  • getGroupConfiguration()
  • getTestdoxGroupConfiguration()
  • getListenerConfiguration()
  • getLoggingConfiguration()
  • getPHPConfiguration()
  • getPHPUnitConfiguration()
  • getTestSuiteConfiguration()
  • Move XML parsing from PHPUnit\Util\Configuration to separate object

@sebastianbergmann sebastianbergmann added the type/refactoring A refactoring that should be applied to make the code easier to understand and maintain label Oct 29, 2019
@sebastianbergmann sebastianbergmann added this to the PHPUnit 8.5 milestone Oct 29, 2019
@sebastianbergmann sebastianbergmann self-assigned this Oct 29, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 29, 2019

Codecov Report

Merging #3914 into master will decrease coverage by 2.2%.
The diff coverage is 87.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3914      +/-   ##
============================================
- Coverage     83.72%   81.52%   -2.21%     
- Complexity     3856     3991     +135     
============================================
  Files           151      171      +20     
  Lines         10218    10840     +622     
============================================
+ Hits           8555     8837     +282     
- Misses         1663     2003     +340
Impacted Files Coverage Δ Complexity Δ
src/Util/Configuration/GroupCollectionIterator.php 0% <0%> (ø) 7 <7> (?)
src/Framework/MockObject/MockBuilder.php 61.11% <100%> (-2.76%) 36 <3> (ø)
src/Util/Configuration/ExtensionCollection.php 100% <100%> (ø) 4 <4> (?)
src/Framework/MockObject/Generator.php 83.96% <100%> (+0.03%) 145 <10> (ø) ⬇️
src/Util/Configuration/Group.php 100% <100%> (ø) 2 <2> (?)
src/Util/Configuration/Groups.php 100% <100%> (ø) 5 <5> (?)
src/Util/Configuration.php 95.04% <100%> (-1.75%) 154 <76> (-32)
...c/Util/Configuration/FilterDirectoryCollection.php 100% <100%> (ø) 5 <5> (?)
src/Util/XdebugFilterScriptGenerator.php 100% <100%> (ø) 5 <5> (-2) ⬇️
src/Util/Configuration/Filter.php 100% <100%> (ø) 9 <9> (?)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfdb50f...bbfa58f. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 1, 2019

Codecov Report

Merging #3914 into master will decrease coverage by 2.8%.
The diff coverage is 85.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3914      +/-   ##
============================================
- Coverage     85.56%   82.76%   -2.81%     
- Complexity     3826     4117     +291     
============================================
  Files           157      216      +59     
  Lines          9678    10531     +853     
============================================
+ Hits           8281     8716     +435     
- Misses         1397     1815     +418
Impacted Files Coverage Δ Complexity Δ
src/TextUI/Configuration/Generator.php 100% <ø> (ø) 1 <0> (?)
...UI/Configuration/Group/GroupCollectionIterator.php 0% <0%> (ø) 7 <7> (?)
.../TextUI/Configuration/Logging/CodeCoverage/Xml.php 0% <0%> (ø) 2 <2> (?)
...onfiguration/Filesystem/FileCollectionIterator.php 0% <0%> (ø) 7 <7> (?)
src/TextUI/Configuration/Logging/TeamCity.php 0% <0%> (ø) 2 <2> (?)
.../TextUI/Configuration/Logging/CodeCoverage/Php.php 0% <0%> (ø) 2 <2> (?)
src/TextUI/Configuration/Logging/TestDox/Xml.php 100% <100%> (ø) 2 <2> (?)
src/TextUI/Configuration/Filter/FilterFile.php 100% <100%> (ø) 2 <2> (?)
src/TextUI/Configuration/Logging/TestDox/Html.php 100% <100%> (ø) 2 <2> (?)
src/TextUI/Configuration/Logging/TestDox/Text.php 100% <100%> (ø) 2 <2> (?)
... and 197 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0b04d...fd303f2. Read the comment docs.

@sebastianbergmann sebastianbergmann force-pushed the refactor/configuration branch 8 times, most recently from f681576 to b00e2eb Compare November 8, 2019 23:59
@sebastianbergmann sebastianbergmann force-pushed the refactor/configuration branch 3 times, most recently from 3dda0f7 to 3f245f6 Compare November 17, 2019 20:36
@sebastianbergmann sebastianbergmann force-pushed the refactor/configuration branch 7 times, most recently from 4faaeb7 to 0556a8a Compare December 1, 2019 04:01
@sebastianbergmann sebastianbergmann force-pushed the refactor/configuration branch 5 times, most recently from e779575 to 12e9d4c Compare December 4, 2019 16:36
@sebastianbergmann sebastianbergmann marked this pull request as ready for review January 24, 2020 10:34
@sebastianbergmann sebastianbergmann merged commit 2effe6e into master Jan 24, 2020
@sebastianbergmann sebastianbergmann deleted the refactor/configuration branch January 24, 2020 10:37
@sebastianbergmann sebastianbergmann restored the refactor/configuration branch February 7, 2020 06:59
@sebastianbergmann sebastianbergmann deleted the refactor/configuration branch February 7, 2020 06:59
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type/refactoring A refactoring that should be applied to make the code easier to understand and maintain

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants