refactor: simplify icon canvas updates #356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the icon canvas updates in
IconCanvas.vue.I'm using
watchEffect()here. It works similar towatch()but you don't need to pass in the source data you want to watch.The
triggerGenerator()function will be executed only if the icon canvas is initialized and it will be executed whenever thecurrentIconin theiconsStoreupdates.It's a good practice in Vue to put normal TypeScript functions into normal TypeScript files, so Vue components only need to manage Vue related code.
The awesome side effect is that you can unit-test those TypeScript functions very easily without needing to mount the Vue components.
That's why I moved the
triggerGenerator()function into thegenerators.tsfile next to thegetMatchingGenerator()function.The component now only needs to call this function.