Open
Conversation
Fixed for PHP8 (used eval + lambda for creating the return function - needed eval for the argName feature) Added the option to set the argName as in the original doT.js by setting the public property "argName" to something like '$myvar'
Update doT.php
Fix UTF-8 characters breaking templates.
Give default value to $def argument of template method
Remove unused $functionCode property and execute method
Corrected the preg_replace for handling single-quotes and slashes in templates
Nzn1 php8 fixes features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP8 compatibility
Configurable template function argument variable name
Allow UTF-8 and single-quotes in templates
Default value of NULL for $def method argument (not required for basic templating)
Minor cleanup of unused code