Merged
Conversation
Owner
Author
|
Oh, I should add: Big thanks to @iboB for the test-must-fail-to-compile code that I have used here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make sure mat += vec does NOT work, and similar. See #113 for the query that motivated this.
Previously
mat += or -= vec worked (even with vec3/vec4 for mat<F, 4>)
mat + or - vec worked
mat == vec worked
mat != vec worked
mat = vec worked (assignment)
you could construct mat<F, 4> from a vec<F, 3> or vec<F, 4> (creating a translation matrix)
Now
mat = vec works if vec size is Nr * Nc (only)
mat == vec doesn't compile
mat != vec doesn't compile
mat +=/-=/+/- vec don't compile
you can't construct mat<F, 4> from a vec<F, 3> or vec<F, 4> (too confusing)
you can still construct mat from a vec of the right size, assumed to contain data in col major order