Merged
Conversation
…being renamed to transpose_inplace
sebsjames
reviewed
Jul 9, 2025
Owner
There was a problem hiding this comment.
Remove " // check this with eigen"
sebsjames
reviewed
Jul 9, 2025
Owner
There was a problem hiding this comment.
Code comment for mat22<F> transpose() noexcept should be "Return the transpose of this matrix"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the behaviour of transpose and inverse was inconsistent. The transpose function in the matrix classes mat22, mat33 and mat44 did a transpose in place, whereas the inverse function returned the inverse of matrix.
Following this PR these matrix classes now have
transpose_inplaceandinverse_inplace, as well astransposeandinversefunctions which return modified matricies, leaving the matrix itself unchanged.