Closed
Conversation
cmelone
force-pushed
the
fix/py-makefile
branch
from
e3a3244 to
ea1eeae
Compare
pcmoore
reviewed
Apr 8, 2026
Member
|
Thanks for the patch @cmelone! Overall I think it looks fine to me, just two small nitpicks (above). |
the Makefile for the python bindings does a check for out of source builds to see if it should copy the .pyx file. However, if `srcdir` and `builddir` are different strings but point to the same directory, the `cp` command will fail. This patch makes the build step more robust by checking if the .pyx file exists in the `builddir` (will resolve to true if srcdir==builddir). Otherwise, it will copy the file over. Signed-off-by: Caetano Melone <melone1@llnl.gov>
Member
|
The CI test failure above is due to a bad merge in the main branch that has since been fixed. No need to rebase @cmelone, that will resolve itself normally when merging. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the Makefile for the python bindings does a check for out of source builds to see if it should copy the .pyx file. However, if
srcdirandbuilddirare different strings but point to the same directory, thecpcommand will fail.This patch makes the build step more robust by checking if the .pyx file exists in the
builddir(will resolve to true if srcdir==builddir). Otherwise, it will copy the file over.