-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Test scapy imports #3247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test scapy imports #3247
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3247 +/- ##
=======================================
Coverage 52.38% 52.38%
=======================================
Files 9 9
Lines 1365 1365
=======================================
Hits 715 715
Misses 650 650 |
5539c19 to
4a6c6d6
Compare
12a81ff to
2426c66
Compare
|
Do you think that we can make this test faster? |
|
Awesome ! Before the changes: After the changes: This is a quite old laptop. On Github Actions, the whole |
|
@gpotter2 do you know why some tests are failing? |
|
No I currently have no idea |
|
Let’s merge this PR?
…Sent from my iPhone
On 13 Jul 2021, at 18:49, gpotter2 ***@***.***> wrote:
No I currently have no idea
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Sure. I disabled a few imports I thought could be problematic. Those are few contrib modules so it's fine if we don't test them |
This PR adds a test that imports every file in a new Python session, just to make sure we stop having those dumb circular issues.
The issue was triggered by the test
fix #3246