Skip to content

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Jun 2, 2021

This PR adds a test that imports every file in a new Python session, just to make sure we stop having those dumb circular issues.

The issue was triggered by the test

fix #3246

@gpotter2 gpotter2 added the tests label Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #3247 (f4ac0ba) into master (cdeea0a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3247   +/-   ##
=======================================
  Coverage   52.38%   52.38%           
=======================================
  Files           9        9           
  Lines        1365     1365           
=======================================
  Hits          715      715           
  Misses        650      650           

@gpotter2 gpotter2 force-pushed the importloops branch 5 times, most recently from 5539c19 to 4a6c6d6 Compare June 5, 2021 22:55
@gpotter2 gpotter2 force-pushed the importloops branch 2 times, most recently from 12a81ff to 2426c66 Compare June 21, 2021 23:31
@gpotter2
Copy link
Member Author

gpotter2 commented Jul 2, 2021

@guedou If you can help debug this it would be greatly appreciated. Should solve #3246 (once and for all), but I don't have an OSX machine to test it

@guedou
Copy link
Member

guedou commented Jul 2, 2021

import.uts does not find any new issue on my macOS.

Do you think that we can make this test faster?

@guedou
Copy link
Member

guedou commented Jul 3, 2021

Awesome !

Before the changes:

passed F66DC992 000.03s Prepare importing all scapy files
passed 816770EE 029.09s Try importing all core separately
passed 1D3DC2E3 117.76s Try importing all layers separately
passed B57BFE53 193.02s Try importing all contribs separately

After the changes:

passed 8FC9A72E 000.06s Prepare importing all scapy files
passed 816770EE 021.66s Try importing all core separately
passed 1D3DC2E3 061.64s Try importing all layers separately
passed B57BFE53 116.30s Try importing all contribs separately

This is a quite old laptop. On Github Actions, the whole .uts takes only 40 seconds.

@guedou
Copy link
Member

guedou commented Jul 3, 2021

@gpotter2 do you know why some tests are failing?

@gpotter2
Copy link
Member Author

No I currently have no idea

@guedou
Copy link
Member

guedou commented Jul 13, 2021 via email

@gpotter2
Copy link
Member Author

Sure. I disabled a few imports I thought could be problematic. Those are few contrib modules so it's fine if we don't test them

@gpotter2 gpotter2 merged commit 66b611c into secdev:master Jul 13, 2021
@gpotter2 gpotter2 deleted the importloops branch July 13, 2021 22:39
@gpotter2 gpotter2 added this to the 2.5.0 milestone Mar 29, 2022
bzalkilani pushed a commit to bzalkilani/scapy that referenced this pull request Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scapy.layers.inet import error on macOS 10.15.7

2 participants