Skip to content

Conversation

@polybassa
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #4208 (ff8886d) into master (0dd08cd) will decrease coverage by 0.40%.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4208      +/-   ##
==========================================
- Coverage   81.77%   81.38%   -0.40%     
==========================================
  Files         331      331              
  Lines       76693    76705      +12     
==========================================
- Hits        62717    62424     -293     
- Misses      13976    14281     +305     
Files Coverage Δ
scapy/contrib/isotp/isotp_native_socket.py 43.39% <0.00%> (ø)
scapy/contrib/cansocket_native.py 78.57% <70.58%> (-6.16%) ⬇️

... and 12 files with indirect coverage changes

@polybassa
Copy link
Contributor Author

This PR aims to fix an issue with timestamps of packets from VCAN sockets on aarch64

@polybassa
Copy link
Contributor Author

More context. This PR solves an issue appearing on aarch64 kernel versions in combination with VCAN sockets. The function get_last_pkt_timestamp (

return self.basecls, pkt, get_last_packet_timestamp(self.ins)
) returns an invalid time value for VCAN sockets on these kernel versions. This PR fixes it by using AUX data instead.

@polybassa polybassa requested a review from gpotter2 December 18, 2023 14:16
@gpotter2 gpotter2 merged commit f9c7d95 into secdev:master Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants