bluetooth: fix HCI_Cmd_Write_Local_Name command #4303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4303 +/- ##
=======================================
Coverage 82.01% 82.02%
=======================================
Files 350 350
Lines 82225 82225
=======================================
+ Hits 67440 67441 +1
+ Misses 14785 14784 -1
|
gpotter2
approved these changes
Mar 23, 2024
Contributor
Author
|
Thank you! |
oskar456
added a commit
to oskar456/scapy
that referenced
this pull request
May 7, 2024
Instead of considering the full IPv4 routing table, we only look for IPv4 default route and IPv6 routes shorter or equal /8 (for instance `2000::/3`). Since the `conf.route6` is not ready yet when we first run, we reload `conf.ifaces` after loading `route6.py`. This fixes secdev#4303. Signed-off-by: Ondřej Caletka <ondrej@caletka.cz>
oskar456
added a commit
to oskar456/scapy
that referenced
this pull request
May 7, 2024
Instead of considering the full IPv4 routing table, we only look for IPv4 default route and IPv6 routes shorter or equal /8 (for instance `2000::/3`). Since the `conf.route6` is not ready yet when we first run, we reload `conf.ifaces` after loading `route6.py`. This fixes secdev#4303. Signed-off-by: Ondřej Caletka <ondrej@caletka.cz>
oskar456
added a commit
to oskar456/scapy
that referenced
this pull request
May 7, 2024
Instead of considering the full IPv4 routing table, we only look for IPv4 default route and IPv6 routes shorter or equal /8 (for instance `2000::/3`). Since the `conf.route6` is not ready yet when we first run, we reload `conf.ifaces` after loading `route6.py`. This fixes secdev#4303. Signed-off-by: Ondřej Caletka <ondrej@caletka.cz>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
cd test && ./run_testsortox)Name field must be 248 bytes!