Skip to content

Conversation

@T3pp31
Copy link
Contributor

@T3pp31 T3pp31 commented Aug 17, 2025

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

i fixed issue#4795
Modify the L3WinSocket.close() method to check for the existence of the self.ins attribute before accessing it.

fixes #4795

T3pp31 added 2 commits August 18, 2025 08:14
Introduces a test to ensure L3WinSocket.close() does not raise AttributeError when called on a partially initialized object. This improves robustness by verifying correct handling of incomplete initialization.
@codecov
Copy link

codecov bot commented Aug 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.98%. Comparing base (d6a25bb) to head (5b1c175).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4820   +/-   ##
=======================================
  Coverage   80.98%   80.98%           
=======================================
  Files         365      365           
  Lines       89112    89112           
=======================================
+ Hits        72167    72171    +4     
+ Misses      16945    16941    -4     
Files with missing lines Coverage Δ
scapy/arch/windows/native.py 68.46% <100.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@T3pp31 T3pp31 marked this pull request as draft August 17, 2025 23:45
@T3pp31 T3pp31 marked this pull request as ready for review August 17, 2025 23:45
@gpotter2
Copy link
Member

Thanks for the PR !

@gpotter2 gpotter2 merged commit f97890d into secdev:master Aug 18, 2025
24 checks passed
@T3pp31 T3pp31 deleted the issue#4795 branch August 18, 2025 08:57
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'L3WinSocket' object has no attribute 'ins'

2 participants