Skip to content

Conversation

@dmillescamps
Copy link
Contributor

Some EC curves have size not a multiple of 8, such as secp521r1. Because of this, it will crash during the Key Exchange with a 50% chance.

Added a unit test that checks for the correct signature size, or will throw an exception before due to an "odd-length" hexadecimal string.

Some EC curves have size not a multiple of 8, such as secp521r1.
Because of this, it will crash during the Key Exchange with a 50% chance.

Added a unit test that checks for the correct signature size, or will throw
an exception before due to an "odd-length" hexadecimal string.
@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.90%. Comparing base (449142a) to head (5bfd82e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4827      +/-   ##
==========================================
- Coverage   80.91%   80.90%   -0.01%     
==========================================
  Files         366      366              
  Lines       90130    90130              
==========================================
- Hits        72927    72921       -6     
- Misses      17203    17209       +6     
Files with missing lines Coverage Δ
scapy/layers/tls/keyexchange.py 86.99% <ø> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guedou
Copy link
Member

guedou commented Aug 27, 2025

Thanks for the PR!

@guedou guedou merged commit 3449fb7 into secdev:master Aug 27, 2025
24 checks passed
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants