Skip to content

SPNEGO.from_cli_arguments: don't ask for password when unrequired #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2025
Merged

SPNEGO.from_cli_arguments: don't ask for password when unrequired #4839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion scapy/layers/spnego.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,7 @@ def from_cli_arguments(
if not valid_ip(target):
hostname = target
target = str(Net(target))

# Check UPN
try:
_, realm = _parse_upn(UPN)
Expand All @@ -678,12 +679,23 @@ def from_cli_arguments(
except ValueError:
# not a UPN: NTLM only
kerberos = False

# Do we need to ask the password?
if HashNt is None and password is None and ST is None:
if all(
x is None
for x in [
ST,
password,
HashNt,
HashAes256Sha96,
HashAes128Sha96,
]
):
# yes.
from prompt_toolkit import prompt

password = prompt("Password: ", is_password=True)

ssps = []
# Kerberos
if kerberos and hostname:
Expand Down Expand Up @@ -731,11 +743,13 @@ def from_cli_arguments(
"Kerberos required but domain not specified in the UPN, "
"or target isn't a hostname !"
)

# NTLM
if not kerberos_required:
if HashNt is None and password is not None:
HashNt = MD4le(password)
ssps.append(NTLMSSP(UPN=UPN, HASHNT=HashNt))

# Build the SSP
return cls(ssps)

Expand Down