Skip to content

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Oct 6, 2025

  • handle scanning on an IP that isn't defined in our routing table, if local to the provided interface.

This is a regression, as it was working before we did the overhaul on routing.

@gpotter2 gpotter2 marked this pull request as ready for review October 6, 2025 09:23
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.88%. Comparing base (12a3752) to head (249b325).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/l2.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4856   +/-   ##
=======================================
  Coverage   80.88%   80.88%           
=======================================
  Files         368      368           
  Lines       90340    90335    -5     
=======================================
+ Hits        73069    73071    +2     
+ Misses      17271    17264    -7     
Files with missing lines Coverage Δ
scapy/interfaces.py 96.31% <100.00%> (ø)
scapy/layers/l2.py 84.76% <66.66%> (+0.81%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 force-pushed the fix-arping-default branch from 3143737 to 249b325 Compare October 6, 2025 10:59
@gpotter2 gpotter2 merged commit 4296eee into secdev:master Oct 12, 2025
24 checks passed
@gpotter2 gpotter2 deleted the fix-arping-default branch October 12, 2025 18:44
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants