Add support for UnifiedPush notification system

[SkypLabs]

Hi there,

As of today, Secluso only supports Firebase for push notifications. Even though this choice is understandable as a starting point, it would be great to add support for more open, privacy-focused, and decentralised solutions.

Support for UnifiedPush would allow users to pick the distributor of their choice, such as ntfy.

Also, I am willing to work on this feature.

[jkaczman]

Hi @SkypLabs,

Thank you for the feature suggestion, I think this is a great idea. My only concern is that UnifiedPush currently only works on Android (not iOS). Do you know of any alternatives that would allow us to support both platforms, or do you see UnifiedPush as best suited for Android only while keeping Firebase for iOS?

[jkaczman]

Hi @SkypLabs,

Thanks again for suggesting this, we’d love to see UnifiedPush support added! After talking it over with @arrdalan, we think the best approach would be to continue support for FCM for iOS (for now), and then provide users with the option of either using FCM or UnifiedPush via a setting in Android. That way, we can move forward on Android without blocking iOS support.

If you’re still interested in contributing, the next step would be to review/sign our Contributor License Agreement (CLA). It’s very similar to Bitwarden’s. I can email you a copy, or if you prefer we can share it directly in this thread. Once that’s squared away, you’re welcome to open a PR or start a draft implementation for review.

Looking forward to hearing your thoughts!

[SkypLabs]

Hey @jkaczman,

Sorry for the late answer.

Thanks again for suggesting this, we’d love to see UnifiedPush support added! After talking it over with @arrdalan, we think the best approach would be to continue support for FCM for iOS (for now), and then provide users with the option of either using FCM or UnifiedPush via a setting in Android. That way, we can move forward on Android without blocking iOS support.

Sounds like to best approach to follow given that iOS is a very restrictive environment regarding push notifications (see UnifedPush FAQ).

If you’re still interested in contributing, the next step would be to review/sign our Contributor License Agreement (CLA). It’s very similar to Bitwarden’s. I can email you a copy, or if you prefer we can share it directly in this thread. Once that’s squared away, you’re welcome to open a PR or start a draft implementation for review.

Please share it directly in this thread.

Maybe you could also include it as part of the Git repository to allow anyone to easily review it. Just a thought.

[jkaczman]

Hello @SkypLabs,

I apologize for the delay, we had to take some time and discuss how to best accomplish this. We've setup an automated tool for the CLAs now, where you can sign via your GitHub account.

Here are the two CLAs. They are mostly identical, and should have the exact same material as Bitwarden's.

• Main Repo (this one): https://cla-assistant.io/secluso/secluso
• Mobile App Repo: https://cla-assistant.io/secluso/mobile_app

If you have any questions or problems regarding the CLAs, please let me know. We are happy to consider modifying it if there's an issue.

[SkypLabs]

Glad to see this feature implemented! In the end, I didn't have enough time to work on it.