Conversation
- Rename directory x402-common to payment-common - Update package name to payment_common - Update all Cargo.toml dependencies - Update all source file imports - Update documentation references Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR successfully renames the x402-common directory to payment-common as part of a broader effort to generalize the payment infrastructure beyond the x402 protocol. The renaming is comprehensive and includes updates to the package name, all import statements, dependency references, and most documentation.
Changes:
- Renamed directory from
x402-commontopayment-commonand updated the Rust package name fromx402_commontopayment_common - Updated all Cargo.toml dependency references across workspace members (payment-config, pay, get-address, create-wallet)
- Updated all import statements and type references in source files to use the new
payment_commonmodule path - Updated documentation in README.md, PLAN.md, and CLAUDE.md to reflect the new naming
Reviewed changes
Copilot reviewed 13 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updated workspace member from x402-common to payment-common |
| payment-common/Cargo.toml | Renamed package from x402_common to payment_common and updated description |
| payment-common/src/lib.rs | New file with common utilities and exports (formerly in x402-common) |
| payment-common/src/error.rs | New file with error types (formerly in x402-common) |
| payment-common/src/config.rs | New file with configuration management (formerly in x402-common) |
| payment-common/src/wallet.rs | New file with wallet operations (formerly in x402-common) |
| payment-config/Cargo.toml | Updated dependency reference from x402_common to payment_common |
| payment-config/src/main.rs | Updated imports and type references to use payment_common |
| pay/Cargo.toml | Updated dependency reference from x402_common to payment_common |
| pay/src/main.rs | Updated imports to use payment_common |
| get-address/Cargo.toml | Updated dependency reference from x402_common to payment_common |
| get-address/src/main.rs | Updated imports to use payment_common |
| create-wallet/Cargo.toml | Updated dependency reference from x402_common to payment_common |
| create-wallet/src/main.rs | Updated imports and type references to use payment_common |
| README.md | Updated crate name in architecture table from x402-common to payment-common |
| PLAN.md | Updated all references to the shared library from x402-common to payment-common |
| CLAUDE.md | Updated directory reference from x402-common/ to payment-common/ |
Comments suppressed due to low confidence (1)
create-wallet/src/main.rs:10
- The documentation comment still references "x402 payments" which should be updated to just "payments" for consistency with the renaming. This comment appears in both the doc comment on line 7 and the command description on line 10.
/// Create a new Ethereum-compatible wallet for x402 payments
#[derive(Parser, Debug)]
#[command(name = "create-wallet")]
#[command(about = "Create a new Ethereum-compatible wallet for x402 payments")]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x402-commontopayment-commonx402_commontopayment_commonTest plan
cargo build --releasesucceedscargo test --allpasses (8 tests)cargo fmt --allapplied🤖 Generated with Claude Code