Split install.md into platform-specific guides#17
Conversation
- Rename install.md to install-claudecode.md (for Claude Code) - Create install-openclaw.md (for OpenClaw, uses ~/.openclaw) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR splits the installation documentation into platform-specific guides for Claude Code and OpenClaw agents. The main change is creating two separate installation guides that differ only in the skill directory paths used by each platform.
Changes:
- Created
install-claudecode.mdwith installation instructions using~/.claude/skills/paymentpath - Created
install-openclaw.mdwith installation instructions using~/.openclaw/skills/paymentpath - Both files are identical except for platform-specific paths and agent platform names
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| install-claudecode.md | Installation guide for Claude Code agents using ~/.claude directory structure |
| install-openclaw.md | Installation guide for OpenClaw agents using ~/.openclaw directory structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| SKILL_DIR="${HOME}/.openclaw/skills/payment" | ||
| mkdir -p "$(dirname "$SKILL_DIR")" | ||
|
|
||
| # Clone the skill directory | ||
| git clone --depth 1 https://github.com/second-state/payment-skill.git /tmp/payment-skill-repo | ||
| cp -r /tmp/payment-skill-repo/skill/* "$SKILL_DIR" |
There was a problem hiding this comment.
The directory setup is incomplete. Line 17 creates the parent directory (/.openclaw/skills/) but line 21 tries to copy files INTO $SKILL_DIR (/.openclaw/skills/payment) which doesn't exist yet. This will cause the cp command to fail. Either change line 17 to mkdir -p "$SKILL_DIR" to create the full path, or change line 21 to cp -r /tmp/payment-skill-repo/skill "$SKILL_DIR" (removing the /*) and adjust line 17 to use dirname.
| echo "OS: $(uname -s), Arch: $(uname -m)" | ||
| ``` | ||
|
|
||
| Supported: Linux/macOS/Windows on x86_64/aarch64 |
There was a problem hiding this comment.
Missing trailing newline at end of file. For consistency with install-claudecode.md and common convention, add a blank line at the end of the file.
| Supported: Linux/macOS/Windows on x86_64/aarch64 | |
| Supported: Linux/macOS/Windows on x86_64/aarch64 |
| git clone --depth 1 https://github.com/second-state/payment-skill.git /tmp/payment-skill-repo | ||
| cp -r /tmp/payment-skill-repo/skill/* "$SKILL_DIR" | ||
| rm -rf /tmp/payment-skill-repo | ||
|
|
||
| # Download platform-specific binaries | ||
| "${SKILL_DIR}/bootstrap.sh" |
There was a problem hiding this comment.
The quick install instructions clone https://github.com/second-state/payment-skill.git at the moving default branch and then immediately execute bootstrap.sh from that clone, which creates a supply-chain risk. If the remote repository or its distribution channel is compromised, users following these steps will run attacker-controlled code with access to their payment wallet and local environment. Consider pinning the clone to a specific trusted tag or commit and/or adding integrity verification (e.g., checksum or signature verification) before executing bootstrap.sh.
Changed from mkdir -p "$(dirname "$SKILL_DIR")" to mkdir -p "$SKILL_DIR" to ensure the destination directory exists before copying files. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Changed `.claude/skills/payment/skill/scripts/` to `~/.claude/skills/payment/scripts/` (removed extra /skill/, added ~/) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skill/SKILL.md
Outdated
| https://github.com/second-state/payment-skill/releases | ||
|
|
||
| Extract to `.claude/skills/payment/skill/scripts/` | ||
| Extract to `~/.claude/skills/payment/scripts/` |
There was a problem hiding this comment.
This path is hardcoded to use ~/.claude/ which is specific to Claude Code. Since the PR creates separate installation guides for Claude Code and OpenClaw (which uses ~/.openclaw/), this documentation should be platform-agnostic. Consider using a placeholder like <SKILL_DIR>/scripts/ or documenting both paths to support users of both platforms.
Use `scripts/` instead of full absolute paths since the paths are relative to the skill directory. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
install.mdtoinstall-claudecode.md(for Claude Code, uses~/.claude)install-openclaw.md(for OpenClaw, uses~/.openclaw)Both guides have identical content except for the skill directory path.
🤖 Generated with Claude Code