Merged
Conversation
nattylinden
force-pushed
the
nattylinden/node24
branch
from
658a74c to
b3a4c5f
Compare
nattylinden
force-pushed
the
nattylinden/node24
branch
3 times, most recently
from
ae437a8 to
7042203
Compare
nattylinden
force-pushed
the
nattylinden/node24
branch
from
7042203 to
bc44a64
Compare
minddrive
approved these changes
Mar 19, 2026
Contributor
minddrive
left a comment
minddrive
left a comment
There was a problem hiding this comment.
Not the most familiar with Node.js / Javascript, but looks good to me!
Contributor
Author
|
Thanks for having a look, @minddrive! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of GitHub's GitHub Actions now use Node 24, as available on runners v2.327.1 (July 2025) and newer. In order to update several dependencies, we would need to compile and/or run with a newer Node than v20. Let's update the action to run on Node 24.
According to the initial work in this project, secondlife/setup-nfpm was initially forked from actions/typescript-action. GitHub have continued to maintain actions/typescript-action since then, including updating it to run on Node 24. In order to reduce how much we're independently inventing how to maintain Actions, let's update to Node 24 by taking up all the outstanding changes made to typescript-action since we created setup-nfpm.
How's this look to y'all? Let me know what you think. Thanks!