-
Notifications
You must be signed in to change notification settings - Fork 5
Update Package Name Across Project to fix README Links and be Consistent with Repo Name #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Previous link for the Releases page was https://github.com/secondlife/sl-vscode-edit/releases , correct link is https://github.com/secondlife/sl-vscode-plugin/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects the GitHub repository link in the README's manual installation instructions, changing from the incorrect sl-vscode-edit to the correct sl-vscode-plugin as specified in package.json.
Key Changes:
- Updated the Releases page URL in the manual installation section from the old repository name to the correct one
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "sl-vscode-edit", | |||
| "name": "sl-vscode-plugin", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it this should probably be plugin, but that has consequences for users.
If this change is to happen it needs to happen sooner than later, before more people are using it.
This is likely to cause duplicate installs of the extension for users manually installing, as it wont replace instances installed with vs-code-edit
I believe the extension is not yet live on the vscode marketplace and if this change is to happen, it needs to happen before it is listed there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are gonna do it, now is the time before I've pushed to a store.
Just fix that end of file on Readme.md
README.md
Outdated
| - Include guards and circular protection | ||
| - Real-time script synchronization | ||
|
|
||
| - Real-time script synchronization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that went the wrong way?
This is the 3rd time somebody has tried to add it.
|
Looks like we were being haunted by an invisible space at the end... making the line technically not blank. |
|
I was wondering why it wasn't working, thanks for the fix! |
Previous link for the Releases page was https://github.com/secondlife/sl-vscode-edit/releases , correct link is https://github.com/secondlife/sl-vscode-plugin/releases