Skip to content

Conversation

@GalaxyLittlepaws
Copy link
Contributor

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the GitHub repository link in the README's manual installation instructions, changing from the incorrect sl-vscode-edit to the correct sl-vscode-plugin as specified in package.json.

Key Changes:

  • Updated the Releases page URL in the manual installation section from the old repository name to the correct one

@@ -1,5 +1,5 @@
{
"name": "sl-vscode-edit",
"name": "sl-vscode-plugin",
Copy link
Contributor

@WolfGangS WolfGangS Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it this should probably be plugin, but that has consequences for users.

If this change is to happen it needs to happen sooner than later, before more people are using it.

This is likely to cause duplicate installs of the extension for users manually installing, as it wont replace instances installed with vs-code-edit

I believe the extension is not yet live on the vscode marketplace and if this change is to happen, it needs to happen before it is listed there.

@GalaxyLittlepaws GalaxyLittlepaws changed the title Update README with correct link for manual installation Update Package Name Across Project to fix README Links and be Consistent Nov 20, 2025
@GalaxyLittlepaws GalaxyLittlepaws changed the title Update Package Name Across Project to fix README Links and be Consistent Update Package Name Across Project to fix README Links and be Consistent with Repo Name Nov 20, 2025
Copy link
Collaborator

@Rider-Linden Rider-Linden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are gonna do it, now is the time before I've pushed to a store.

Just fix that end of file on Readme.md

README.md Outdated
- Include guards and circular protection
- Real-time script synchronization

- Real-time script synchronization
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that went the wrong way?

@Rider-Linden
Copy link
Collaborator

Looks like we were being haunted by an invisible space at the end... making the line technically not blank.

@Rider-Linden Rider-Linden merged commit 70d6de0 into secondlife:develop Nov 20, 2025
3 checks passed
@GalaxyLittlepaws
Copy link
Contributor Author

I was wondering why it wasn't working, thanks for the fix!

@GalaxyLittlepaws GalaxyLittlepaws deleted the patch-1 branch November 20, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants