[Wine] SLVersionChecker crashes on wine due to lack of powershell support

[FelixWolf]

Traceback (most recent call last):
  File "SLVersionChecker.py", line 659, in <module>
  File "SLVersionChecker.py", line 655, in main
  File "SLVersionChecker.py", line 138, in leap
  File "SLVersionChecker.py", line 246, in leap_body
  File "util.py", line 100, in wrapper
  File "update_manager.py", line 406, in query_vvm
  File "update_manager.py", line 304, in make_VVM_UUID_hash
IndexError: list index out of range

My understanding is wine doesn't support powershell properly, as such the version checker will crash because the returned string is empty at

viewer-manager/src/update_manager.py

Line 304 in baf845e

muuid = [line for line in muuid.splitlines() if line][-1].rstrip()

This occurs because [line for line in "".splitlines() if line][-1] evaluates all lines that are equal to "" as False, thus a empty array can occur.

There is two ways to fix this, I'm not sure which way is preferred:
1.

muuid = [line for line in muuid.splitlines() if line]
if len(muuid) == 0:
    muuid = None
else:
    muuid = muuid[-1].rstrip()

try:
    muuid = [line for line in muuid.splitlines() if line][-1].rstrip()
except IndexError:
    muuid = None

[FelixWolf]

Additionally, I noticed that if the machine UUID fails to get, it just fakes it with a random UUID. Wouldn't it be better to use uuid.UUID(bytes=hashlib.md5(uuid.getnode().to_bytes(6)).digest()) to get a relatively stable UUID instead of a random UUID?

[FelixWolf]

Created two fixes and tested them:

• Wine fix: FelixWolf@59072d8
• Stable fake MUUID: FelixWolf@71fa5ea

If either of these are of interest, LMK and I'll create PRs for them! I went ahead and made PRs for them because the "LMK to make a PR" is a sort of "don't ask to ask".