RemoveItemWarn was Removed in 2025.06 but still referenced and causes an invalid notification

[Hecklezz]

Environment

Second Life Release 7.2.1.17108480561 (64bit)

Rest of Environment-

Release Notes

You are at 64.1, 213.1, 21.2 in LunaCy Retreat located at simhost-068a460a7ad77d2d7.agni
SLURL: http://maps.secondlife.com/secondlife/LunaCy%20Retreat/64/213/21
(global coordinates 168,768.0, 306,389.0, 21.2)
Second Life RC LeTigre 2025-09-16.17777995432
Release Notes

CPU: Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (3600.01 MHz)
Memory: 16302 MB
OS Version: Microsoft Windows 10 64-bit (Build 19045.6332)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: NVIDIA GeForce RTX 2080/PCIe/SSE2

Windows Graphics Driver Version: 32.0.15.8115
OpenGL Version: 4.6.0 NVIDIA 581.15

Window size: 1920x1062
Font Size Adjustment: 96pt
UI Scaling: 1
Draw distance: 512m
Bandwidth: 3000kbit/s
LOD factor: 4
Render quality: 5
Texture memory: 8192MB
Disk cache: Max size 2150.4 MB (77.0% used)

J2C Decoder Version: KDU v7.10.4
Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.24.2 / OpenAL Community / OpenAL Soft: OpenAL Soft
Dullahan: 1.14.0.202408091639
CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54
Chromium: 118.0.5993.54
LibVLC Version: 3.0.21
Voice Server Version: Vivox 4.10.0000.32327.5fc3fe7c.5942f08

Packets Lost: 1/23,349 (0.0%)
October 11 2025 04:15:36

Description

PR with fix: #4812

The Notification "RemoveItemWarn" was removed in 2025.06 here- c4392d4 and replaced with CantModifyContentInNoModTask, however the old notification is still referenced and used here-

viewer/indra/newview/llpanelobjectinventory.cpp

Line 391 in 2cdcd33

LLNotificationsUtil::add("RemoveItemWarn", LLSD(), payload, boost::bind(&remove_task_inventory_callback, _1, _2, mPanel));

viewer/indra/newview/llpanelobjectinventory.cpp

Line 420 in 2cdcd33

LLNotificationsUtil::add("RemoveItemWarn", LLSD(), payload, boost::bind(&remove_task_inventory_callback, _1, _2, mPanel));

Screenshot triggering the invalid notification-

Note: Other languages besides English still have the old RemoveItemWarn translations and no translations for CantModifyContentInNoModTask

There is also another bug related to this deleting, but I'll open a new issue for it.

Reproduction steps

1. Have a no-mod item with no-mod content inside.
2. Edit the object and go to the contents panel
3. Try and delete a no-mod content such as a script using the DELETE key on the keyboard (not right-click delete)
4. Click yes to the pop-up and observe the notification error

---

This repo is using Opire - what does it mean? 👇

💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️‍♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #4811 either in the PR description or in a PR's comment.

🪙 Also, everyone can tip any user commenting /tip 20 @Hecklezz (replace 20 with the amount, and @Hecklezz with the user to tip).

📖 If you want to learn more, check out our documentation.

[Dan-Linden]

Passed QA.
Verified on Second Life Release 7.2.3.19118091373 on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/566