SL-19591 Prompt user to save current settings as Graphics Preset before enabling AutoFPS#170
Merged
marchcat merged 1 commit intoDRTVWR-539from Apr 17, 2023
Merged
Conversation
…re enabling AutoFPS
akleshchev
reviewed
Apr 17, 2023
|
|
||
| void LLFloaterPerformance::enableAutotuneWarning() | ||
| { | ||
| if (!gSavedPerAccountSettings.getBOOL("HadEnabledAutoFPS") && LLPerfStats::tunables.userAutoTuneEnabled) |
Contributor
There was a problem hiding this comment.
This probably shouldn't be in draw() and if you are putting it into draw at least make getBool into a static.
Contributor
Author
There was a problem hiding this comment.
draw() is where the settings are being changed, so saving them before that.
Otherwise, sounds reasonable, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.