SL-19744: Remove LLErrorThread and LLAppViewer::handleViewerCrash()#225
Merged
marchcat merged 2 commits intoDRTVWR-580-maint-Tfrom May 23, 2023
Merged
SL-19744: Remove LLErrorThread and LLAppViewer::handleViewerCrash()#225marchcat merged 2 commits intoDRTVWR-580-maint-Tfrom
marchcat merged 2 commits intoDRTVWR-580-maint-Tfrom
Conversation
marchcat
approved these changes
May 23, 2023
Contributor
|
Will pull this into DRTVWR-580 Maint T. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLErrorThread is, ironically, not thread-safe. Recently it has been a source of shutdown hangs.
LLErrorThread's sole responsibility is to call handleViewerCrash() when LLApp::isError(). The surprising part is that I can find no code that calls either LLApp::setError() or setStatus(APP_STATUS_ERROR). In other words, I believe that no one ever calls LLAppViewer::handleViewerCrash().
Remove all that unused code. LLErrorThread is supposed to be part of the general LLApp machinery, but to actually be robust, it would have to be rewritten.
I'd like to request a QA pass over this branch to verify that it's no worse -- either while running or providing a crash report -- than the release viewer.
Unless some problem turns up, please pull this into an upcoming maint viewer. I marked it "Draft" because of course it shouldn't be merged directly into main.