Skip to content

SL-18778 Crash at LLVoiceClient::removeObserver#25

Merged
akleshchev merged 1 commit intoDRTVWR-570-maint-Qfrom
SL-18778
Dec 6, 2022
Merged

SL-18778 Crash at LLVoiceClient::removeObserver#25
akleshchev merged 1 commit intoDRTVWR-570-maint-Qfrom
SL-18778

Conversation

@akleshchev
Copy link
Contributor

@akleshchev akleshchev commented Dec 2, 2022

Adjusted vlean order.

singletoneInstanceExists() makes no sense to me. It's a non-static member of a potentially dead singleton yet we prod it... invalid_pointer->is_valid()?

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@akleshchev akleshchev merged commit f7010e4 into DRTVWR-570-maint-Q Dec 6, 2022
@akleshchev akleshchev deleted the SL-18778 branch December 6, 2022 02:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants