#3322 No confirmation is shown when gifting all your money#3323
Merged
#3322 No confirmation is shown when gifting all your money#3323
Conversation
marchcat
approved these changes
Jan 2, 2025
Contributor
marchcat
left a comment
marchcat
left a comment
There was a problem hiding this comment.
This looks reasonable, but shouldn't it still be like gStatusBar->getBalance() >= amount?
Contributor
Author
I believe we should ask for a confirmation even if the balance is not enough First, when the amount is big, it makes sense to always double-check the target and sum |
akleshchev
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.