Skip to content

SL-18911 My Land Holdings floater crashes viewer on the Xcode branch#47

Merged
akleshchev merged 1 commit intoxcode-14.1from
SL-18911-xcode-14.1
Jan 10, 2023
Merged

SL-18911 My Land Holdings floater crashes viewer on the Xcode branch#47
akleshchev merged 1 commit intoxcode-14.1from
SL-18911-xcode-14.1

Conversation

@akleshchev
Copy link
Contributor

@akleshchev akleshchev commented Jan 10, 2023

Revert part of "DRTVWR-575: Address review comments on Xcode 14.1 type tweaks."

Crash was reproduced when assigning areastr to llsd, but likely present in other cases as well.

@akleshchev
SL-18911 My Land Holdings floater crashes viewer on the Xcode/+Monter…
91e7489 
…ey branches

Revert part of "DRTVWR-575: Address review comments on Xcode 14.1 type tweaks."
@akleshchev akleshchev merged commit f3cd329 into xcode-14.1 Jan 10, 2023
@akleshchev akleshchev deleted the SL-18911-xcode-14.1 branch January 10, 2023 17:38
logue added a commit to logue/viewer that referenced this pull request Apr 28, 2023
@logue
Squashed commit of the following:
48357af 
commit 4e47e53
Merge: 6d2bfe7 86846ff
Author: Andrey Lihatskiy <alihatskiy@productengine.com>
Date:   Wed Apr 19 23:15:28 2023 +0300

    Merge branch 'SL-19594-fakesmile' into DRTVWR-577-maint-S

commit 86846ff
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Wed Apr 19 15:35:47 2023 -0400

    SL-19594: Update to bugsplat build 579696

commit 6d2bfe7
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Mon Apr 3 21:26:17 2023 +0300

    SL-17659 The display name reset button

commit a6daa3a
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Fri Mar 31 17:47:07 2023 +0300

    SL-19432 External group links dont load in SL

commit 302bfb6
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Thu Mar 30 16:13:48 2023 +0300

    SL-19491 Revert SL-19346

    This reverts part of commit 0c2b00e.

commit 5217e6b
Merge: f6ba830 c7053a6
Author: Andrey Lihatskiy <alihatskiy@productengine.com>
Date:   Thu Mar 30 00:25:16 2023 +0300

    Merge branch 'main' into DRTVWR-577-maint-S

    # Conflicts:
    #	indra/cmake/CMakeLists.txt
    #	indra/newview/skins/default/xui/es/floater_tools.xml

commit f6ba830
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Mar 22 20:19:23 2023 +0200

    SL-18876 Update fmod studion to version 2.02.13

    Should fix "Radio/Stream hiccups at a regular rate during playback"

commit d080ec2
Author: Andrey Lihatskiy <alihatskiy@productengine.com>
Date:   Wed Mar 22 19:09:26 2023 +0200

    SL-4126 Updated contributions.txt

commit 9bbdd92
Author: Ansariel <ansariel.hiller@phoenixviewer.com>
Date:   Wed Mar 22 10:28:51 2023 +0100

    SL-4126: Create NVIDIA application profile for Second Life specific settings

commit d611734
Author: akleshchev <117672381+akleshchev@users.noreply.github.com>
Date:   Sat Mar 4 02:29:48 2023 +0200

    SL-15752 Reduce default graphical quality on machines with little memory (secondlife#105)

commit 22018af
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Fri Mar 3 23:04:06 2023 +0200

    SL-17584 Better logging for setShaders crashes

commit a546aa2
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Feb 14 22:49:50 2023 +0200

    SL-4126 Second Life messing up NVIDIA drivers

    Disable NvAPI by default

commit 204072d
Author: akleshchev <117672381+akleshchev@users.noreply.github.com>
Date:   Fri Mar 3 00:26:46 2023 +0200

    SL-19327 Disable crash reporting for Win7 (secondlife#102)

    Win7 is no longer supported and is below minimal requirements

commit 99a23af
Author: Andrey Lihatskiy <alihatskiy@productengine.com>
Date:   Wed Feb 22 01:31:30 2023 +0200

    SL-19244 Layout fix for the media type field in About Land

commit 2c37650
Author: Andrey Lihatskiy <alihatskiy@productengine.com>
Date:   Wed Feb 22 01:21:24 2023 +0200

    SL-19245 Layout fix for the Chat tab in Preferences

commit 375d01e
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Fri Feb 17 02:31:35 2023 +0200

    SL-18735 Fix scroll not following item for long enough

commit 8032b2d
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Fri Feb 17 00:49:32 2023 +0200

    SL-19204 Crash at removeObserver

    A lot of reports about crashes in voice's removeObserver with no indication of the cause, all MAC specific. By this point terminate should have been called and mVoiceModule should be null, yet callstaks suggest it isn't.

    Commit clears LLVoiceClient beforehand to avoid the issue entirely, but issue lies elsewhere and 'voice' crash is just a symptom.

commit d998bcb
Author: Henri Beauchamp <sldevel@users.noreply.github.com>
Date:   Mon Feb 13 18:34:00 2023 +0100

    SL-19110 revert LLUUID::combine() to old algorithm to match server code. (secondlife#75)

    As it happens, the change in the LLUUID::combine() algorithm introduced by one
    of my previous commits is causing invalid assets creation (seen with
    some clothing items, such as Shape and Universal types); obviously, the server
    is using the old algorithm for UUID validation purpose of these assets.

    This commit reverts LLUUID::combine() code to use LLMD5.

commit 50f9f18
Author: Maxim Nikolenko <mnikolenko@productengine.com>
Date:   Fri Feb 10 19:02:42 2023 +0200

    SL-19194 update slurl handling (secondlife#74)

commit e87d771
Author: Maxim Nikolenko <maximnproductengine@lindenlab.com>
Date:   Fri Feb 10 02:30:05 2023 +0200

    SL-19189 FIXED My Outfits system items have circle over them

commit f1d2478
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Thu Feb 9 23:12:06 2023 +0200

    SL-19190 Laggy behavior when turning

    GetAsyncKeyState is luggy in some conditions and no longer needed due to fix for SL-16845 - all 'up' keys get reset when leaving window

commit 6c54c9f
Merge: 8e03f92 8d21d29
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Thu Feb 9 21:55:14 2023 +0200

    Merge branch 'main' into DRTVWR-577-maint-S

    # Conflicts:
    #	indra/llcommon/llsdserialize.cpp
    #	indra/llcommon/llsdserialize.h
    #	indra/newview/llfilepicker.h
    #	indra/newview/llfilepicker_mac.h
    #	indra/newview/llfilepicker_mac.mm

commit 8e03f92
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Thu Feb 9 01:05:14 2023 +0200

    SL-18970 Heavy name cache spam

    If cap fails viewer can spam hundreds of "get legacy for agent" to logs which freezes it.

commit fee55c8
Author: Brad Payne (Vir Linden) <vir@lindenlab.com>
Date:   Tue Feb 7 21:42:57 2023 +0000

    SL-19161 - logging of basic translation stats in ViewerStats

commit 1377173
Author: Andrey Lihatskiy <alihatskiy@productengine.com>
Date:   Tue Feb 7 17:44:17 2023 +0200

    INTL-370
    INTL-370 Translate the word Feed for new Viewer Profiles

commit e937089
Merge: 11b9b6f a6615b3
Author: Andrey Lihatskiy <alihatskiy@productengine.com>
Date:   Thu Feb 2 21:22:50 2023 +0200

    Merge branch 'contribute' into DRTVWR-577-maint-S

commit a6615b3
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Jan 31 19:35:10 2023 +0200

    SL-19110 Fix coding policy

commit 8518154
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Jan 31 18:48:16 2023 +0200

    SL-19110 Fix xxhash build link and properly register contribution

commit 9438ef5
Author: Henri Beauchamp <sldevel@users.noreply.github.com>
Date:   Tue Jan 31 17:42:51 2023 +0100

    SL-19110 Fast hashing classes for use in place of the slow LLMD5, where speed matters. (secondlife#64)

    This commit adds the HBXX64 and HBXX128 classes for use as a drop-in
    replacement for the slow LLMD5 hashing class, where speed matters and
    backward compatibility (with standard hashing algorithms) and/or
    cryptographic hashing qualities are not required.
    It also replaces LLMD5 with HBXX* in a few existing hot (well, ok, just
    "warm" for some) paths meeting the above requirements, while paving the way for
    future use cases, such as in the DRTVWR-559 and sibling branches where the slow
    LLMD5 is used (e.g. to hash materials and vertex buffer cache entries), and
    could be use such a (way) faster algorithm with very significant benefits and
    no negative impact.

    Here is the comment I added in indra/llcommon/hbxx.h:

    // HBXXH* classes are to be used where speed matters and cryptographic quality
    // is not required (no "one-way" guarantee, though they are likely not worst in
    // this respect than MD5 which got busted and is now considered too weak). The
    // xxHash code they are built upon is vectorized and about 50 times faster than
    // MD5. A 64 bits hash class is also provided for when 128 bits of entropy are
    // not needed. The hashes collision rate is similar to MD5's.
    // See https://github.com/Cyan4973/xxHash#readme for details.

commit 21b5928
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Sat Jan 28 02:01:49 2023 +0200

    SL-19097 Crash when selecting a model for upload and waiting too long

    Should be fixed by SL-18996, but just in case user decides to select a model while viewer closes

commit 27080dc
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Thu Jan 26 16:58:00 2023 +0200

    SL-18996 make MacOS picker dialogs modeless to avoid disconnects #2

commit 2398a28
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Jan 25 20:53:01 2023 +0200

    SL-18996 [WIP] MacOS make picker dialogs non-modal to avoid disconnects #1

commit 11b9b6f
Author: Andrey Lihatskiy <alihatskiy@productengine.com>
Date:   Tue Jan 24 09:19:00 2023 +0200

    INTL-477 Translation update for Maint S

commit 1109fca
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Jan 24 14:14:37 2023 +0200

    SL-19025 Fix for object's context menu

    Inspect and copy doesn't work for face or child selection. Disable them in such cases.

commit a94f907
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Fri Jan 20 23:43:48 2023 +0200

    SL-18989 Saved notifications some times stops displaying information

commit e3a90ba
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Jan 18 22:00:01 2023 +0200

    SL-3033 flv files prompt download instead of playing

    Viewer doesn't support web downloads, it should be safe to assume stream and play it

commit 8ff51bd
Merge: a1931d8 8ec8732
Author: Andrey Lihatskiy <alihatskiy@productengine.com>
Date:   Mon Jan 16 23:17:19 2023 +0200

    Merge branch 'contribute' into DRTVWR-577-maint-S

commit 8ec8732
Author: Andrey Lihatskiy <alihatskiy@productengine.com>
Date:   Mon Jan 16 23:07:51 2023 +0200

    SL-18893 OSX buildfix

commit 20b16dd
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Mon Jan 16 19:52:20 2023 +0200

    MacOS Build fix

commit a1931d8
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Mon Jan 16 04:42:33 2023 +0200

    SL-18735 Using "Find original" in main inventory tab breaks inventory view

    Fixes folders being invidible (missing arrange)
    Fixes sroll to target not working reliably

commit 484e3b6
Merge: 77a42cb f3cd329
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Mon Jan 16 20:07:02 2023 +0200

    Merge branch 'xcode-14.1' into DRTVWR-577-maint-S

    D577 should have picked part of the changes from contribute branch, picking up the rest for the sake of branch specific crash fixes

commit 77a42cb
Merge: de77dc3 b34d209
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Mon Jan 16 20:04:57 2023 +0200

    Merge branch 'contribute' into DRTVWR-577-maint-S

commit b34d209
Author: Pantera Północy <panterapolnocy@gmail.com>
Date:   Mon Jan 16 19:03:58 2023 +0100

    SL-18937 Add missing panel_* files in Polish translation (secondlife#50)

commit de77dc3
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Mon Jan 16 19:52:20 2023 +0200

    MacOS Build fix

commit bea9300
Merge: a0c3d69 5d6371f
Author: Andrey Lihatskiy <alihatskiy@productengine.com>
Date:   Mon Jan 16 07:05:01 2023 +0200

    Merge branch 'contribute' into DRTVWR-577-maint-S

commit 5d6371f
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Jan 10 20:05:01 2023 +0200

    SL-18937 Update contributions

commit 9dcf206
Merge: 7419037 77444ca
Author: akleshchev <117672381+akleshchev@users.noreply.github.com>
Date:   Tue Jan 10 19:47:53 2023 +0200

    SL-18937 Merge pull request secondlife#45 from PanteraPolnocy/contribute

    Translate missing control_*, floater_* menu_* and few panel_* files in Polish directory; Fix localizability in various English XMLs

commit f3cd329
Author: akleshchev <117672381+akleshchev@users.noreply.github.com>
Date:   Tue Jan 10 19:38:44 2023 +0200

    SL-18911 My Land Holdings floater crashes viewer on the Xcode/+Monterey branches (secondlife#47)

    Revert part of "DRTVWR-575: Address review comments on Xcode 14.1 type tweaks."
    Crash was reproduced when assigning areastr to llsd, but likely present in other cases of assigning ui strings to llsd (instead of going for lluistring's result directly copy constructor was engaged and either copy or original crashed due to invalid pointers, copy shouldn't have been created).

commit 7419037
Author: Fawrsk <fawrsk@gmail.com>
Date:   Tue Jan 10 05:43:27 2023 -0400

    SL-18893 Fixes for pull requests secondlife#38, secondlife#41, and secondlife#42 (secondlife#46)

    Eliminate unnecessary copies, and remove uses of auto

commit 9c250f1
Merge: d0f115a 8767e69
Author: akleshchev <117672381+akleshchev@users.noreply.github.com>
Date:   Tue Jan 10 11:38:34 2023 +0200

    SL-18893 Cleanup for loops in llcommon to use C++11 range based for loops (secondlife#44)

    * Cleanup for loops in llcommon to use C++11 range based for loops
    * Eliminate needless copies

commit 8767e69
Author: Fawrsk <fawrsk@gmail.com>
Date:   Mon Jan 9 19:19:12 2023 -0400

    Eliminate needless copies

commit 77444ca
Author: PanteraPolnocy <panterapolnocy@gmail.com>
Date:   Sat Jan 7 20:36:50 2023 +0100

    Translate missing control_*, floater_* menu_* and few panel_* files in Polish directory; Fix localizability in various English XMLs

commit 9e743c9
Author: Fawrsk <fawrsk@gmail.com>
Date:   Sat Jan 7 00:38:12 2023 -0400

    Cleanup for loops in llcommon to use C++11 range based for loops

commit d0f115a
Author: Fawrsk <fawrsk@gmail.com>
Date:   Thu Jan 5 07:42:27 2023 -0400

    SL-18893 Cleanup for loops in llcharacter to use C++11 range based for loops (secondlife#42)

commit bdfb47c
Author: Fawrsk <45524015+Fawrsk@users.noreply.github.com>
Date:   Wed Jan 4 21:06:12 2023 -0400

    SL-18893 Clean up for loops in llaudio to use C++11 range based for loops (secondlife#41)

commit 99c040e
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Wed Jan 4 17:18:31 2023 -0500

    DRTVWR-575: Fix possible bad indexing in LLSD::operator[](size_t).

    One could argue that passing a negative index to an LLSD array should do
    something other than shrug and reference element [0], but as that's legacy
    behavior, it seems all too likely that the viewer sometimes relies on it.

    This specific problem arises if the index passed to operator[]() is negative
    -- either with the previous Integer parameter or with size_t (which of course
    reinterprets the negative index as hugely positive). The non-const
    ImplArray::ref() overload checks parameter 'i' and, if it appears negative,
    sets internal 'index' to 0.

    But in the next stanza, if (index >= existing size()), it calls resize() to
    scale the internal array up to one more than the requested index. The trouble
    is that it passed resize(i + 1), not the adjusted resize(index + 1).

    With a requested index of exactly -1, that would pass resize(0), which would
    result in the ensuing array[0] reference being invalid.

    With a requested index less than -1, that would pass resize(hugely positive)
    -- since, whether operator[]() accepts signed LLSD::Integer or size_t,
    resize() accepts std::vector::size_type. Given that the footprint of an LLSD
    array element is at least a pointer, the number of bytes required for
    resize(hugely positive) is likely to exceed available heap storage.

    Passing the adjusted resize(index + 1) should defend against that case.

commit 64a42ac
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Jan 4 23:52:41 2023 +0200

    SL-18904 Remove unused translation files

commit 5bc16b9
Merge: 5ea7cec bfa8239
Author: akleshchev <117672381+akleshchev@users.noreply.github.com>
Date:   Wed Jan 4 23:36:40 2023 +0200

    SL-18904 Merge pull request secondlife#40 from PanteraPolnocy

    A small batch of changes in Polish translation subdirectory

commit 5ea7cec
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Jan 4 22:21:20 2023 +0200

    SL-18893 Update list of contributors

commit 4093d5b
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Wed Jan 4 15:13:02 2023 -0500

    DRTVWR-575: Use llsdutil.h functions for LLFloaterLandHoldings LLSD

    LLFloaterLandHoldings::postBuild() was constructing an LLSD structure by
    assigning each map entry and array element one at a time. Chorazinallen
    identified a crash bug possibly caused by destroying that LLSD structure.
    Diagnostically try building it using nested llsd::map() and llsd::array()
    calls instead to see if that improves matters.

commit aa112ef
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Wed Jan 4 12:04:56 2023 -0500

    DRTVWR-575: Fix bug in macOS micro_sleep().

    The compiler was deducing an unsigned type for the difference (U64 desired
    microseconds - half KERNEL_SLEEP_INTERVAL_US). When the desired sleep was less
    than that constant, the difference went hugely positive, resulting in a very
    long snooze.

    Amusingly, forcing that U64 result into an S32 num_sleep_intervals worked only
    *because* of integer truncation: the high-order bits were discarded, resulting
    in a negative result as intended.

    Ensuring that both integer operands are signed at the outset, though, produces
    a more formally correct result.

commit bb71815
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Tue Jan 3 18:06:45 2023 -0500

    DRTVWR-575: Replace some LLSDArray() usage with llsd::array().

    It seems newer compilers have a different interpretation of exactly when to
    engage LLSDArray's copy constructor. In particular, this assignment:

    some_LLSD_map[key] = LLSDArray(...)(...)...;

    used to convert the LLSDArray object directly to LLSD; now it first calls the
    custom copy constructor, which embeds the intended array within an outer array
    before assigning it into the containing map.

    The newer llsd::array() function avoids that problem because what it returns
    is already an LLSD object.

    Taking inventory of LLSDArray assignments of that form turned up a number of
    workarounds like LLSD(LLSDArray(...)). Replacing those with llsd::array() is
    both simpler and more readable.

    Tip of the hat to Chorazinallen for surfacing this issue!

commit bfa8239
Author: PanteraPolnocy <panterapolnocy@gmail.com>
Date:   Tue Jan 3 23:21:24 2023 +0100

    Polish translation: Leftovers cleanup (files not present in /en/)

commit 030be1d
Author: PanteraPolnocy <panterapolnocy@gmail.com>
Date:   Tue Jan 3 23:03:17 2023 +0100

    Widgets cleanup in Polish translation (up to 6.6.9), fix translatability for density_ctrl.xml file

commit 74a9280
Author: Fawrsk <45524015+Fawrsk@users.noreply.github.com>
Date:   Tue Jan 3 17:08:15 2023 -0400

    SL-18893 Clean up for loops in llappearance to use C++11 range based for loops (secondlife#38)

commit 43496fe
Author: Pantera Północy <panterapolnocy@gmail.com>
Date:   Tue Jan 3 20:49:23 2023 +0100

    SL-18891 Remove duplicate entry in settings file

commit 9ef4867
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Jan 3 14:35:27 2023 +0200

    SL-18874 Rigged mesh upload crash when using Bounding Box physics

commit 796d97d
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Dec 14 20:49:56 2022 +0200

    SL-18384 Fix NSException for keyboard handling

    Affects accent keys for diacritical marks

commit 0ffe9ff
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Tue Dec 13 21:25:16 2022 +0200

    SL-15175 Updates for TP states while the viewer is minimized

commit e5bd3fc
Merge: fe4f0fc 0dd287d
Author: akleshchev <117672381+akleshchev@users.noreply.github.com>
Date:   Tue Dec 13 04:20:42 2022 +0200

    SL-15175 Merge pull request secondlife#26 from sldevel/contribute

    Fix failures to update the TP states while the viewer is minimized.

commit fe4f0fc
Merge: 6a97e13 a0c3d69
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Mon Dec 12 15:27:38 2022 -0500

    DRTVWR-565: Merge branch 'main' into contribute

commit 6a97e13
Merge: 12f66fd f3f3c49
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Mon Dec 12 15:24:29 2022 -0500

    DRTVWR-565: Merge branch 'master' into contribute

commit 12f66fd
Merge: 6de5986 2b7ba3f
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Mon Dec 12 13:27:57 2022 -0500

    DRTVWR-565: Merge branch 'origin/contribute' into DRTVWR-565

commit 2b7ba3f
Merge: 80e3950 7d9249d
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Mon Dec 12 17:44:47 2022 +0200

    Merge branch 'xcode-14.1' into contribute

commit 80e3950
Author: Andrey Kleshchev <>
Date:   Mon Dec 12 17:20:50 2022 +0200

    SL-8839 Make About Land resizable

commit 95f682f
Merge: f064cba 769bf46
Author: nat-goodspeed <nat@lindenlab.com>
Date:   Thu Dec 8 13:33:29 2022 -0500

    Merge pull request secondlife#28 from secondlife/sl-14399

    SL-14399: Ditch overflow queue LLViewerAssetStorage::mCoroWaitList.

commit f064cba
Author: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date:   Wed Dec 7 20:10:41 2022 +0200

    SL-14399 Remove obsolete code

    mCoroWaitList covers all assets not just landmarks

commit 769bf46
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Wed Dec 7 09:50:02 2022 -0500

    SL-14399: Ditch overflow queue LLViewerAssetStorage::mCoroWaitList.

    mCoroWaitList was introduced to prevent an assertion failure crash:
    LLCoprocedureManager never expects to fill LLCoprocedurePool::mPendingCoprocs
    queue. The queue limit was arbitrarily set to 4096 some years ago, but in
    practice LLViewerAssetStorage can post way more requests than that.

    LLViewerAssetStorage checked whether the target LLCoprocedureManager pool's
    queue looked close to full, and if so posted the pending request to its
    mCoroWaitList instead. But then it had to override the base LLAssetStorage
    method checkForTimeouts() to continually check whether pending tasks could be
    moved from mCoroWaitList to LLCoprocedureManager.

    A simpler solution is to enlarge LLCorpocedureManager::DEFAULT_QUEUE_SIZE, the
    upper limit on mPendingCoprocs. Since mCoroWaitList was an unlimited queue,
    making DEFAULT_QUEUE_SIZE "very large" does not increase the risk of runaway
    memory consumption.

commit 0dd287d
Author: Henri Beauchamp <sldev@free.fr>
Date:   Wed Dec 7 00:01:34 2022 +0100

    Fix failures to update the TP states while the viewer is minimized.

    This is a fix for: https://jira.secondlife.com/browse/BUG-230616

commit 7d9249d
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Tue Dec 6 17:16:56 2022 -0500

    DRTVWR-575: Try to avoid comparison warnings in llclamp()

commit 9a7e638
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Tue Dec 6 15:46:05 2022 -0500

    DRTVWR-575: Defend unescape_string() against empty line.

    The unsigned index arithmetic was problematic in that case.

commit db1d757
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Tue Dec 6 14:40:11 2022 -0500

    DRTVWR-575: Update a few more int lengths in llsdserialize.{h,cpp}.

commit 73aced6
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Tue Dec 6 13:59:06 2022 -0500

    DRTVWR-575: Use llssize (signed size_t) for max_bytes parameters.

    Since LLSDSerialize::SIZE_UNLIMITED is negative, passing that through unsigned
    size_t parameters could result in peculiar behavior.

commit 8f6ffd4
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Tue Dec 6 13:04:35 2022 -0500

    DRTVWR-575: Introduce LLKeyBind::endNonEmpty()

    and use it to replace dubious loops in asLLSD() and trimEmpty().

commit 8ff81fc
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Tue Dec 6 11:16:55 2022 -0500

    DRTVWR-575: Keep BufferArray::findBlock() in int domain.

commit 59b826e
Merge: d776638 d14c675
Author: Signal Linden <signal@lindenlab.com>
Date:   Mon Nov 21 16:02:02 2022 -0800

    Merge pull request secondlife#4 from secondlife/signal/stale

    Close stale PRs

commit d776638
Author: Henri Beauchamp <sldev@free.fr>
Date:   Sat Nov 19 21:42:41 2022 +0100

    Fix a thread safety issue in the GL image worker.

    LLViewerTexture::mNeedsCreateTexture needs to be an attomic bool since
    it is written both in the main thread and in the GL image worker thread.

    We can now enable threaded bump maps creation as a result of this fix.

    I have read the CLA Document and I hereby sign the CLA

commit b841dad
Merge: 783926e b5688b8
Author: Signal Linden <signal@lindenlab.com>
Date:   Mon Nov 21 14:18:12 2022 -0800

    Merge pull request secondlife#8 from Ansariel/master

    Update message template URL after move to GitHub

commit b5688b8
Author: Ansariel <ansariel.hiller@phoenixviewer.com>
Date:   Mon Nov 21 21:15:01 2022 +0100

    Update default URL for message template in template_verifier.py as well

commit 6c843bc
Author: Ansariel <ansariel.hiller@phoenixviewer.com>
Date:   Mon Nov 21 20:46:46 2022 +0100

    Update message template URL after move to GitHub

commit d14c675
Author: Bennett Goble <signal@lindenlab.com>
Date:   Fri Nov 18 07:43:29 2022 -0800

    Mark PRs as stale after 60 days, close them automatically if no response
    after 7 days.

commit c3ddd70
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Sun Nov 13 06:10:02 2022 -1000

    DRTVWR-575: Explain that NSInteger is really int64_t.

commit 690a502
Merge: 4349cb6 076737c
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Sun Nov 13 05:59:40 2022 -1000

    DRTVWR-575: Merge brad's xcode-14.1 fixes with nat's

commit 4349cb6
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Sat Nov 12 18:59:21 2022 -1000

    DRTVWR-575: Address review comments on Xcode 14.1 type tweaks.

    Introduce LLSD template constructors and assignment operators to disambiguate
    construction or assignment from any integer type to Integer, likewise any
    floating point type to Real. Use new narrow() function to validate
    conversions.

    For LLSD method parameters converted from LLSD::Integer to size_t, where the
    method previously checked for a negative argument, make it now check for
    size_t converted from negative: in other words, more than S32_MAX. The risk of
    having a parameter forced from negative to unsigned exceeds the risk of a
    valid length or index over that max.

    In lltracerecording.cpp's PeriodicRecording, now that mCurPeriod and
    mNumRecordedPeriods are size_t instead of S32, defend against subtracting 1
    from 0.

    Use narrow() to validate newly-introduced narrowing conversions.

    Make llclamp() return the type of the raw input value, even if the types of
    the boundary values differ.

    std::ostream::tellp() no longer returns a value we can directly report as a
    number. Cast to U64.

commit 076737c
Author: Brad Kittenbrink <brad@lindenlab.com>
Date:   Fri Nov 11 18:09:23 2022 -0800

    DRTVWR-575 fix LLGetDarwinOSInfo for xcode-14.1.  NSInteger is now 64 bits

commit 22f6ade
Author: Brad Kittenbrink <brad@lindenlab.com>
Date:   Fri Nov 11 17:07:52 2022 -0800

    DRTVWR-575 fix LLWorkerThread subclasses to be compatiblie with recent size_t changes in base class

commit 6bc0614
Author: Brad Kittenbrink <brad@lindenlab.com>
Date:   Fri Nov 11 16:35:51 2022 -0800

    DRTVWR-575 xcode-14.1 compatibility fix.  add more overloads for stricter size_t conversions

commit 6ec534e
Author: Brad Kittenbrink <brad@lindenlab.com>
Date:   Fri Nov 11 15:31:46 2022 -0800

    DRTVWR-575 xcode-14.1 compatibility fix.  add overloads for stricter integer conversions

commit cd997f2
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Fri Nov 4 17:21:30 2022 -0400

    DRTVWR-575: Introduce llssize (signed size_t) and narrow() function.

    llssize is for a function parameter that should accept a size or index
    (derived from size_t, which is 64 bits in a 64-bit viewer) but might need to
    go negative for flag values. We've historically used S32 for that purpose, but
    Xcode 14.1 complains about trying to pass size_t to S32.

    narrow() is a template function that casts a wider type (e.g. size_t or
    llssize) to a narrower type (e.g. S32 or U32), with validation in
    RelWithDebInfo builds. It verifies (using assert()) that the value being
    truncated can in fact fit into the target type.

commit a2a723f
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Thu Nov 3 15:19:49 2022 -0400

    DRTVWR-575: Suppress remaining size_t truncation warnings for now.

commit 5a74f76
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Thu Nov 3 15:18:32 2022 -0400

    DRTVWR-575: A few more tweaks addressing size_t wider than 32 bits.

commit 9522a0b
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Thu Nov 3 14:58:32 2022 -0400

    DRTVWR-575: Fix llcommon assumptions that size_t fits in 4 bytes.

    It's a little distressing how often we have historically coded S32 or U32 to
    pass a length or index.

    There are more such assumptions in other viewer subdirectories, but this is a
    start.

commit 206993f
Author: Nat Goodspeed <nat@lindenlab.com>
Date:   Thu Nov 3 13:46:19 2022 -0400

    DRTVWR-575: Forbid Xcode 14.1 from implicitly signing every target.

    Or rather, attempting to implicitly sign. On TeamCity we must explicitly sign
    using viewer_manifest.py. On a developer system, without these changes, Xcode
    produces many errors of the form:
    error: An empty identity is not valid when signing a binary for the product
    type 'Command-line Tool'. (in target 'INTEGRATION_TEST_lldir' from project
    'SecondLife')
    and refuses to compile anything at all.

    Thanks to Rye Mutt and NickyD. Also thanks Geir Nøklebye for additional
    settings to help tame Xcode 14.1 warnings.

# Conflicts:
#	indra/newview/skins/default/xui/ja/floater_avatar_textures.xml
#	indra/newview/skins/default/xui/ja/floater_camera.xml
#	indra/newview/skins/default/xui/ja/floater_camera_presets.xml
#	indra/newview/skins/default/xui/ja/floater_edit_day_cycle.xml
#	indra/newview/skins/default/xui/ja/floater_edit_sky_preset.xml
#	indra/newview/skins/default/xui/ja/floater_edit_water_preset.xml
#	indra/newview/skins/default/xui/ja/floater_environment_settings.xml
#	indra/newview/skins/default/xui/ja/floater_facebook.xml
#	indra/newview/skins/default/xui/ja/floater_flickr.xml
#	indra/newview/skins/default/xui/ja/floater_forget_user.xml
#	indra/newview/skins/default/xui/ja/floater_hardware_settings.xml
#	indra/newview/skins/default/xui/ja/floater_linkreplace.xml
#	indra/newview/skins/default/xui/ja/floater_people.xml
#	indra/newview/skins/default/xui/ja/floater_preferences_view_advanced.xml
#	indra/newview/skins/default/xui/ja/floater_preview_trash.xml
#	indra/newview/skins/default/xui/ja/floater_profile.xml
#	indra/newview/skins/default/xui/ja/floater_save_camera_preset.xml
#	indra/newview/skins/default/xui/ja/floater_twitter.xml
#	indra/newview/skins/default/xui/ja/menu_gallery_outfit_tab.xml
#	indra/newview/skins/default/xui/ja/menu_viewer.xml
#	indra/newview/skins/default/xui/ja/notifications.xml
#	indra/newview/skins/default/xui/ja/panel_edit_classified.xml
#	indra/newview/skins/default/xui/ja/panel_edit_pick.xml
#	indra/newview/skins/default/xui/ja/panel_edit_profile.xml
#	indra/newview/skins/default/xui/ja/panel_facebook_friends.xml
#	indra/newview/skins/default/xui/ja/panel_facebook_photo.xml
#	indra/newview/skins/default/xui/ja/panel_facebook_place.xml
#	indra/newview/skins/default/xui/ja/panel_facebook_status.xml
#	indra/newview/skins/default/xui/ja/panel_flickr_account.xml
#	indra/newview/skins/default/xui/ja/panel_flickr_photo.xml
#	indra/newview/skins/default/xui/ja/panel_group_creation_sidetray.xml
#	indra/newview/skins/default/xui/ja/panel_group_roles.xml
#	indra/newview/skins/default/xui/ja/panel_login.xml
#	indra/newview/skins/default/xui/ja/panel_notification_list_item.xml
#	indra/newview/skins/default/xui/ja/panel_outfit_gallery.xml
#	indra/newview/skins/default/xui/ja/panel_outfit_gallery_item.xml
#	indra/newview/skins/default/xui/ja/panel_pick_info.xml
#	indra/newview/skins/default/xui/ja/panel_picks.xml
#	indra/newview/skins/default/xui/ja/panel_preferences_sound.xml
#	indra/newview/skins/default/xui/ja/panel_prim_media_controls.xml
#	indra/newview/skins/default/xui/ja/panel_region_environment.xml
#	indra/newview/skins/default/xui/ja/panel_twitter_account.xml
#	indra/newview/skins/default/xui/ja/panel_twitter_photo.xml
#	indra/newview/skins/default/xui/ja/strings.xml
#	indra/newview/skins/default/xui/ja/teleport_strings.xml
#	indra/newview/skins/default/xui/ja/widgets/density_ctrl.xml
@roxanneskelly roxanneskelly mentioned this pull request Aug 19, 2024
Closed
@maxim-productengine maxim-productengine linked an issue Sep 23, 2025 that may be closed by this pull request
After mistyping a region name into the location bar, search should open populated with the region that was typed. #4719
Closed
@maxim-productengine maxim-productengine removed a link to an issue Sep 23, 2025
After mistyping a region name into the location bar, search should open populated with the region that was typed. #4719
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxim-productengine maxim-productengine maxim-productengine approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akleshchev @maxim-productengine