-
Notifications
You must be signed in to change notification settings - Fork 95
Fix XUI parser warnings: #4917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix XUI parser warnings: #4917
Conversation
* LLFloaterMarketplace::postBuild calls parent method which already tries to find the webbrowser control with a different name and adds itself as observer * Incorrect attribute name "tooltip" in panel_preferences_move.xml
| layout="topleft" | ||
| left="0" | ||
| name="marketplace_contents" | ||
| name="webbrowser" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two other places are also using marketplace_contents, in llviewermedia.cpp and llviewerwindow.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was only one in llviewermedia.cpp - fixed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry, it's there in develop, but was removed in 2025.08
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same problem is probably present in LLFloaterSearch::postBuild()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaaaaaand fixed those as well.
Question: Why is it everytime I open search I have to click the cookie banner thing away? This also happens on current release and is unrelated to these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also happens on current release and is unrelated to these changes.
I think 2025.07 is removing cef's folder each launch or something like that. #4908
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also happens on current release and is unrelated to these changes.
I think 2025.07 is removing cef's folder each launch or something like that. #4908
But it also happens in release 7.2.1 - which AFAIK is 2025.06 - and before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think before 7.2.2 it was a problem with cef instances being locked from files by each other since they were sharing those files. Only one instance could use the files. In 7.2.2 they got individual directories for that. But I'm not entirely in the loop on the topic of cef, so I might be wrong.
|
Thank you! |
Fixes for XUI parser warnings: