[#4987] Fix crash in updateDistance updating LOD on null mVObjp #4988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hecklezz <tj8@live.com.au>
Hecklezz
changed the title
akleshchev
approved these changes
Nov 12, 2025
Geenz
approved these changes
Nov 12, 2025
Contributor
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4987
This PR simply null checks mVObjp before calling updateLOD to try prevent the viewer from crashing.
Note: If this function should return much earlier in the case of mVObjp being null, or some alternative to alleviate this issue, please provide a suggestion on what to do instead and I'll update this PR.