Skip to content

Conversation

@RyeMutt
Copy link
Contributor

@RyeMutt RyeMutt commented Nov 28, 2025

Description

Replace boost::assign usage with modern c++ brace initialization to reduce dependency on boost

Related Issues

  • Please link to a relevant GitHub issue for additional context.
    • Bug Fix: Link to an issue that includes reproduction steps and testing guidance.
    • Feature/Enhancement: Link to an issue with a write-up, rationale, and requirements.

Issue Link:


Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

Copilot finished reviewing on behalf of akleshchev November 30, 2025 21:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the codebase by replacing deprecated boost::assign usage with C++11 brace initialization syntax, reducing dependency on Boost libraries. The changes make the code more readable and align with modern C++ practices.

  • Removes boost::assign::list_of and boost::assign::map_list_of usage across multiple files
  • Replaces with direct brace initialization for containers (vectors, sets, maps)
  • Removes unnecessary Boost header includes and using declarations

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
indra/test/llevents_tut.cpp Replaced list_of() with brace initialization for test assertions; contains type mismatches on lines 293, 325, and 345
indra/newview/llpresetsmanager.cpp Converted camera control list from boost::assign::list_of to brace-initialized vector
indra/newview/llfeaturemanager.cpp Replaced graphics level names initialization with brace syntax
indra/newview/llcommandlineparser.cpp Converted unmapped options set to single-line brace initialization
indra/llfilesystem/tests/lldir_test.cpp Updated test expectations to use brace initialization instead of list_of()
indra/llfilesystem/lldir.cpp Converted static maps and sets to brace initialization; updated ENT macro syntax
indra/llcommon/tests/llstring_test.cpp Replaced list_of() in test assertions with brace initialization; contains unused variable on line 768
indra/llcommon/tests/lldependencies_test.cpp Updated dependency test assertions to use brace initialization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Signed-off-by: Rye <rye@alchemyviewer.org>
@akleshchev akleshchev merged commit 416ab83 into secondlife:develop Dec 1, 2025
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code modernization and cleanup contributions

2 participants