-
Notifications
You must be signed in to change notification settings - Fork 95
Replace boost::assign usage with modern c++ brace initialization #5068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
098a0db to
f608415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes the codebase by replacing deprecated boost::assign usage with C++11 brace initialization syntax, reducing dependency on Boost libraries. The changes make the code more readable and align with modern C++ practices.
- Removes
boost::assign::list_ofandboost::assign::map_list_ofusage across multiple files - Replaces with direct brace initialization for containers (vectors, sets, maps)
- Removes unnecessary Boost header includes and using declarations
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| indra/test/llevents_tut.cpp | Replaced list_of() with brace initialization for test assertions; contains type mismatches on lines 293, 325, and 345 |
| indra/newview/llpresetsmanager.cpp | Converted camera control list from boost::assign::list_of to brace-initialized vector |
| indra/newview/llfeaturemanager.cpp | Replaced graphics level names initialization with brace syntax |
| indra/newview/llcommandlineparser.cpp | Converted unmapped options set to single-line brace initialization |
| indra/llfilesystem/tests/lldir_test.cpp | Updated test expectations to use brace initialization instead of list_of() |
| indra/llfilesystem/lldir.cpp | Converted static maps and sets to brace initialization; updated ENT macro syntax |
| indra/llcommon/tests/llstring_test.cpp | Replaced list_of() in test assertions with brace initialization; contains unused variable on line 768 |
| indra/llcommon/tests/lldependencies_test.cpp | Updated dependency test assertions to use brace initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Signed-off-by: Rye <rye@alchemyviewer.org>
f608415 to
f539c57
Compare
Description
Replace boost::assign usage with modern c++ brace initialization to reduce dependency on boost
Related Issues
Issue Link:
Checklist
Please ensure the following before requesting review:
Additional Notes