Clean up dead code and dead tests#5160
Merged
akleshchev merged 7 commits intosecondlife:develop-linuxfrom Dec 16, 2025
Merged
Conversation
akleshchev
approved these changes
Dec 15, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes obsolete code including legacy headers, platform-specific workarounds, and unused functionality that is no longer needed in the current codebase.
Key changes include:
- Removal of legacy TeamCity CI integration code and test workarounds
- Cleanup of macOS-specific build files and header workarounds
- Elimination of unused particle system packet serialization code
- Removal of dead utility classes (LLStreamQueue, LLBase32, LLSphere, LLToolView)
Reviewed changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| indra/test/test.cpp | Removed CTYPE_WORKAROUND and LLTCTestCallback for TeamCity integration |
| indra/newview/*.h/.cpp | Removed legacy macOS prefix headers and unused UI panels/tools |
| indra/llmessage/partsyspacket.* | Removed entire particle system packet serialization implementation |
| indra/llmath/llsphere.* | Removed LLSphere geometry utility class and tests |
| indra/llmath/*.h | Removed legacy wrapper headers (camera.h, coordframe.h, timer.h) |
| indra/llcommon/llstreamqueue.* | Removed LLStreamQueue buffer implementation and tests |
| indra/llcommon/llbase32.* | Removed base32 encoding utility |
| indra/llcommon/*.h | Removed workaround headers (fix_macros.h, ctype_workaround.h, mutex.h) and updated includes |
| indra/llcorehttp/tests/*.hpp | Removed TeamCity-specific test skip conditions |
| indra/llwindow/llwindowmacosx.h | Removed fix_macros.h include |
| indra/llfilesystem/lldiriterator.cpp | Removed fix_macros.h include |
| indra/newview/CMakeLists.txt | Removed references to deleted headers |
| indra/llmessage/CMakeLists.txt | Removed partsyspacket from build |
| indra/llmath/CMakeLists.txt | Removed llsphere and legacy headers from build |
| indra/llcommon/CMakeLists.txt | Removed deleted files from build and test configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Clean up dead macos files Clean up dead windows build files Signed-off-by: Rye <rye@alchemyviewer.org>
Signed-off-by: Rye <rye@alchemyviewer.org>
Signed-off-by: Rye <rye@alchemyviewer.org>
Signed-off-by: Rye <rye@alchemyviewer.org>
Signed-off-by: Rye <rye@alchemyviewer.org>
Signed-off-by: Rye <rye@alchemyviewer.org>
Signed-off-by: Rye <rye@alchemyviewer.org>
181f37a to
30d5227
Compare
Contributor
Author
|
Fixed the conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Issue Link:
Checklist
Please ensure the following before requesting review:
Additional Notes