Skip to content

Clean up dead code and dead tests#5160

Merged
akleshchev merged 7 commits intosecondlife:develop-linuxfrom
RyeMutt:rye/deadcode8
Dec 16, 2025
Merged

Clean up dead code and dead tests#5160
akleshchev merged 7 commits intosecondlife:develop-linuxfrom
RyeMutt:rye/deadcode8

Conversation

@RyeMutt
Copy link
Copy Markdown
Contributor

@RyeMutt RyeMutt commented Dec 15, 2025

Description

  • Clean up dead legacy headers and compiler work arounds
  • Clean up dead macos files
  • Clean up dead windows build files
  • Clean up dead partsyspacket code
  • Clean up dead LLStreamQueue code and related tests
  • Clean up dead LLBase32 code
  • Clean up dead LLSphere code and related tests
  • Clean up dead TeamCity build output and work arounds from tests
  • Remove dead LLLooksHistoryPanel LLPanelIMControlPanel and LLToolView

Related Issues

  • Please link to a relevant GitHub issue for additional context.
    • Bug Fix: Link to an issue that includes reproduction steps and testing guidance.
    • Feature/Enhancement: Link to an issue with a write-up, rationale, and requirements.

Issue Link:


Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

@akleshchev akleshchev requested a review from Copilot December 15, 2025 22:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes obsolete code including legacy headers, platform-specific workarounds, and unused functionality that is no longer needed in the current codebase.

Key changes include:

  • Removal of legacy TeamCity CI integration code and test workarounds
  • Cleanup of macOS-specific build files and header workarounds
  • Elimination of unused particle system packet serialization code
  • Removal of dead utility classes (LLStreamQueue, LLBase32, LLSphere, LLToolView)

Reviewed changes

Copilot reviewed 50 out of 50 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
indra/test/test.cpp Removed CTYPE_WORKAROUND and LLTCTestCallback for TeamCity integration
indra/newview/*.h/.cpp Removed legacy macOS prefix headers and unused UI panels/tools
indra/llmessage/partsyspacket.* Removed entire particle system packet serialization implementation
indra/llmath/llsphere.* Removed LLSphere geometry utility class and tests
indra/llmath/*.h Removed legacy wrapper headers (camera.h, coordframe.h, timer.h)
indra/llcommon/llstreamqueue.* Removed LLStreamQueue buffer implementation and tests
indra/llcommon/llbase32.* Removed base32 encoding utility
indra/llcommon/*.h Removed workaround headers (fix_macros.h, ctype_workaround.h, mutex.h) and updated includes
indra/llcorehttp/tests/*.hpp Removed TeamCity-specific test skip conditions
indra/llwindow/llwindowmacosx.h Removed fix_macros.h include
indra/llfilesystem/lldiriterator.cpp Removed fix_macros.h include
indra/newview/CMakeLists.txt Removed references to deleted headers
indra/llmessage/CMakeLists.txt Removed partsyspacket from build
indra/llmath/CMakeLists.txt Removed llsphere and legacy headers from build
indra/llcommon/CMakeLists.txt Removed deleted files from build and test configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread indra/llcommon/lockstatic.h Outdated
Comment thread indra/llcommon/llcoros.h
Clean up dead macos files

Clean up dead windows build files

Signed-off-by: Rye <rye@alchemyviewer.org>
Signed-off-by: Rye <rye@alchemyviewer.org>
Signed-off-by: Rye <rye@alchemyviewer.org>
Signed-off-by: Rye <rye@alchemyviewer.org>
Signed-off-by: Rye <rye@alchemyviewer.org>
Signed-off-by: Rye <rye@alchemyviewer.org>
@RyeMutt
Copy link
Copy Markdown
Contributor Author

RyeMutt commented Dec 15, 2025

Fixed the conflict.

@akleshchev akleshchev merged commit ddf0e5a into secondlife:develop-linux Dec 16, 2025
13 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 16, 2025
@RyeMutt RyeMutt deleted the rye/deadcode8 branch December 19, 2025 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants