#3612 Don't immediately fail download on startup, wait for the region#5184
Merged
akleshchev merged 1 commit intorelease/2026.01from Dec 24, 2025
Merged
#3612 Don't immediately fail download on startup, wait for the region#5184akleshchev merged 1 commit intorelease/2026.01from
akleshchev merged 1 commit intorelease/2026.01from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses asset loading failures that occur during viewer startup when the region is not yet available. Instead of immediately failing asset download requests when no region is set, the code now waits for the region to become available (with a timeout) during the world initialization phase.
Key changes:
- Added logic to suspend asset download coroutines until the agent's region becomes available during startup
- Improved cleanup of signal connections in both the new region-waiting code and existing capabilities-waiting code
- Added proper timeout handling for region availability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
It's probably smarter to make asset storage wait with requests in general, but that would require a stronger separation from cache which is functional already and can be loading assets, so I'm pausing individual requests instead, there is a maximum of 12, so there should be no 'bloat' from waiting coros.
akleshchev
force-pushed
the
andreyk/viewer_3612_3
branch
from
5a2265c to
b92df3f
Compare
marchcat
approved these changes
Dec 23, 2025
maxim-productengine
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After doing some further testing around assets I found out that a lot of assets failed to load on startup because there was no region yet. Hense needing to wait for region to become ready.
It's probably smarter to make asset storage wait with requests in general, but that would require a stronger separation from cache which is functional already and can be loading assets, so I'm pausing individual requests instead, there is a maximum of 12, so there should be no 'bloat' from waiting coros.