Skip to content

Fix types for vector multiplication in lua type definitions#5191

Merged
marchcat merged 1 commit intosecondlife:project/lua_editorfrom
WolfGangS:project/lua_editor-vector_mul_types_fix
Dec 31, 2025
Merged

Fix types for vector multiplication in lua type definitions#5191
marchcat merged 1 commit intosecondlife:project/lua_editorfrom
WolfGangS:project/lua_editor-vector_mul_types_fix

Conversation

@WolfGangS
Copy link
Copy Markdown
Contributor

Description

Fix types for vector multiplication and division in lua types xml

Issues resolved

  • vector * number was left out of multiplication
  • return type of multiplication is always a vector
  • vector * vector is not a number, * does not perform a dot product in slua
  • vector / vector was left out of division

Related Issues

Resolves secondlife/sl-vscode-plugin#56


Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Signed-off-by: WolfGangS <flamin2k8@gmail.com>
@WolfGangS WolfGangS changed the title Fix types for vector multiplication Fix types for vector multiplication in lua type definitions Dec 30, 2025
Copy link
Copy Markdown
Contributor

@marchcat marchcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marchcat marchcat merged commit 394aba1 into secondlife:project/lua_editor Dec 31, 2025
18 of 24 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants