Skip to content

#5083 Fix external editor default open handling failing to work on mac and windows#5246

Merged
akleshchev merged 1 commit intosecondlife:developfrom
RyeMutt:rye/5083
Jan 9, 2026
Merged

#5083 Fix external editor default open handling failing to work on mac and windows#5246
akleshchev merged 1 commit intosecondlife:developfrom
RyeMutt:rye/5083

Conversation

@RyeMutt
Copy link
Contributor

@RyeMutt RyeMutt commented Jan 9, 2026

Description

Fixes external editor default open handling failing to work on mac and windows.

Windows was failing due to the %S in %SystemRoot% triggering the file path replacement

Mac was due to failing to specify text editor mode to open

Related Issues

Issue Link: #5083


Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

@github-actions github-actions bot added the c/cpp label Jan 9, 2026
@akleshchev akleshchev linked an issue Jan 9, 2026 that may be closed by this pull request
@akleshchev akleshchev merged commit 6939649 into secondlife:develop Jan 9, 2026
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fallback to OS open handler in external editor

2 participants