#5241 Crash at onIdleUpdateFavorites#5257
Merged
maxim-productengine merged 1 commit intodevelopfrom Jan 12, 2026
Merged
Conversation
marchcat
approved these changes
Jan 12, 2026
akleshchev
reviewed
Jan 12, 2026
indra/llcommon/llapp.h
Outdated
|
|
||
| std::string mDumpPath; //output path for google breakpad. Dependency workaround. | ||
|
|
||
| static bool sDisconnected; |
Contributor
There was a problem hiding this comment.
Why not do it like this?
bool isDisconnected() == 0;
bool LLAppViewer::isDisconnected()
{
return gDisconnected;
}
Or not move gDisconnected elsewhere?
Contributor
Author
There was a problem hiding this comment.
gDisconnected lives in llappviewer, so it can't be reached from non newview classes.
Yes, the idea was to get rid of gDisconnected later and to use only LLAppViewer::isDisconnected(). But I thought it would be too many changes not completely related to this crash.
Contributor
Author
There was a problem hiding this comment.
On the other hand, we can just move gDisconnected to llapp
maxim-productengine
force-pushed
the
maxim/develop-5241
branch
from
93a7a80 to
890a83a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crash seems to be happening after disconnecting, so simple check should be enough. (but we couldn't access gDisconnected from /llui, so moved it to llapp)