Fix locale thousands separator producing '?' on Linux with multibyte UTF-8 separators#5550
Merged
marchcat merged 1 commit intodevelop-linuxfrom Mar 18, 2026
Merged
Fix locale thousands separator producing '?' on Linux with multibyte UTF-8 separators#5550marchcat merged 1 commit intodevelop-linuxfrom
marchcat merged 1 commit intodevelop-linuxfrom
Conversation
…UTF-8 separators getThousandsSeparator() and getMonetaryThousandsSeparator() extracted only the first byte of localeconv()->thousands_sep, truncating multibyte UTF-8 separator characters (e.g. non-breaking space U+00A0). The incomplete byte was then embedded via %c format specifier, producing invalid UTF-8 rendered as '?' in notifications like avatar complexity. Return the full separator string and use string concatenation instead of %c.
Contributor
Author
|
This one was originally approved in #5466, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's just a clean cherry-pick of the change from #5466.
Original description: