#5655 Fix freeze on purging cef cache#5680
Merged
akleshchev merged 1 commit intorelease/2026.02from Apr 21, 2026
Merged
Conversation
Contributor
|
Your changes assumes that the user only ever has 1 viewer open at once, otherwise if they have more than 1, renaming the entire cache folder will fail every time. In the implementation I did in Firestorm, if the parent folder was unable to be renamed, I then looped every pid cache folder and tried to rename each one individually, and only those not in use by the other viewer will get renamed and will be deleted. If that is fine and intended, then ignore me :) |
Contributor
Author
|
Makes sense, thank you. |
maxim-productengine
approved these changes
Apr 20, 2026
akleshchev
force-pushed
the
andreyk/5655_purge
branch
from
20befb1 to
28842eb
Compare
Contributor
Author
|
Remade to move folders individually, should still be faster than deletion. |
marchcat
approved these changes
Apr 20, 2026
maxim-productengine
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle multi-second freeze on startup due to cef cleanup.
Move parent folders, if that fails (locked by other instance), move folders inside. In theory moving folders might still cause a small delay, but it should be a lot less than recursive deletion of folders and files (as 'delete' operation removes all files individually).