#2965 Indicate when role members aren't loaded#5692
Merged
akleshchev merged 1 commit intodevelopfrom Apr 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a UI indicator in the Group Roles panel so users can distinguish between an actually-empty “Assigned Members” list and a list that’s empty because member data hasn’t been loaded yet (only fetched when visiting the Members tab).
Changes:
- Add a new XUI
<text>control (“Members are not loaded”) to the Roles footer panel. - Wire the new control into
LLPanelGroupRolesSubTaband toggle its visibility fromupdate(). - Initialize and store a pointer to the new UI control in the roles subtab class.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| indra/newview/skins/default/xui/en/panel_group_roles.xml | Adds the “members_not_loaded” text control to the Roles UI. |
| indra/newview/llpanelgrouproles.h | Adds a member pointer for the new UI label control. |
| indra/newview/llpanelgrouproles.cpp | Fetches the control in postBuildSubTab() and toggles visibility in update(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maxim-productengine
approved these changes
Apr 22, 2026
akleshchev
force-pushed
the
andreyk/viewer_2965
branch
from
08b2a36 to
6830f36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Members only get loaded when you switch to members tab, show that list is not loaded, not empty.