Get pregenerated config files from the simulator cap and make them available through the websocket. by Rider-Linden · Pull Request #5739 · secondlife/viewer

Rider-Linden · 2026-04-29T21:47:10Z

Description

Adds support for downloading lsl and lua syntax definitions from the simulator. Make these files visible to external editors through the JSONRPC server.

Related Issues

secondlife/sl-vscode-plugin#66

Additional Notes

…cap when available to retrieve all language definition files and cache them locally. Retrieve the default definition files from the LSL definitions precompiled library.

Copilot

Pull request overview

Adds viewer-side support for fetching LSL/Luau syntax definition files from the simulator (new ScriptDefinitions capability), caching them locally, and exposing both the in-memory keyword data and cached files to external editors via the JSON-RPC WebSocket server.

Changes:

Introduces LLSyntaxDefCache to manage per-region syntax ID tracking, downloading, caching, and keyword access for both LSL and Luau.
Extends the external editor JSON-RPC API to list and fetch cached syntax definition files (language.syntax.cache, language.syntax.get) and updates protocol documentation accordingly.
Packages default syntax definition files into app_settings/syntax_default and removes the legacy types_lua_default.xml.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
indra/newview/viewer_manifest.py	Packages default syntax definition files into `app_settings/syntax_default`.
indra/newview/llviewerregion.cpp	Adds the `ScriptDefinitions` capability name.
indra/newview/llsyntaxid.h	Replaces prior syntax managers with `LLSyntaxDefCache` API surface (keywords + cache access).
indra/newview/llsyntaxid.cpp	Implements capability detection, download coroutines, caching, and keyword loading.
indra/newview/llscripteditorws.h	Adds JSON-RPC handlers for syntax cache listing and file retrieval.
indra/newview/llscripteditorws.cpp	Registers new JSON-RPC methods and advertises `syntax_cache` feature flag in handshake.
indra/newview/llscripteditor.cpp	Switches keyword initialization to `LLSyntaxDefCache`.
indra/newview/llpreviewscript.cpp	Switches syntax ID change callback wiring to `LLSyntaxDefCache`.
indra/newview/app_settings/types_lua_default.xml	Removes the legacy Lua types definition file.
indra/llmessage/llcorehttputil.h	Minor whitespace change.
indra/llmessage/llcorehttputil.cpp	Updates LLSD response parsing to use `LLSDSerialize::deserialize()`.
doc/external-editor-json-rpc.md	Documents new syntax cache methods and updates protocol details.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+    result.erase(LLCoreHttpUtil::HttpCoroutineAdapter::HTTP_RESULTS);
+
+    setKeywords(memcached_keywords["lsl_keywords.xml"], memcached_keywords["lua_keywords.xml"]);
+    LLAppViewer::instance()->postToMainCoro(
+        [this]()
+        {
+            mSyntaxIDChangedSignal();
+        });


Rider-Linden · 2026-04-29T22:12:30Z

 bool responseToLLSD(HttpResponse * response, bool log, LLSD & out_llsd)
 {
    // Convert response to LLSD
    BufferArray * body(response->getBody());
-    if (!body || !body->size())
+    size_t body_size(body ? body->size() : 0);


@copilot apply changes based on this feedback

Fixed in d3fa87f. Added (void)log; to suppress the unused-parameter warning and updated the comment to accurately describe that LLSDSerialize::deserialize() handles XML, binary, and notation LLSD encodings (not just XML).

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-04-29T22:23:21Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Copilot

Pull request overview

Adds viewer-side support for fetching LSL/Luau syntax definition assets from simulator capabilities, caching them on disk, and exposing both in-memory keyword LLSD and raw cached files to external editors via the JSON-RPC WebSocket server.

Changes:

Package default syntax definition files into app_settings/syntax_default and add the new ScriptDefinitions capability name.
Replace legacy per-language syntax managers with a unified LLSyntaxDefCache that can fetch via either ScriptDefinitions (preferred) or legacy LSLSyntax.
Extend the external editor JSON-RPC API to list and fetch cached syntax definition files, and document the new methods/features.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
indra/newview/viewer_manifest.py	Packages default syntax definition files into the viewer.
indra/newview/llviewerregion.cpp	Registers the new `ScriptDefinitions` capability name.
indra/newview/llsyntaxid.h	Introduces `LLSyntaxDefCache` public API for keywords + cache access.
indra/newview/llsyntaxid.cpp	Implements fetching/caching logic for legacy and defs-cap responses.
indra/newview/llscripteditorws.h	Adds JSON-RPC handlers for syntax cache list/get.
indra/newview/llscripteditorws.cpp	Registers and implements `language.syntax.cache` and `language.syntax.get`; advertises `syntax_cache` feature.
indra/newview/llscripteditor.cpp	Switches keyword initialization to `LLSyntaxDefCache`.
indra/newview/llpreviewscript.cpp	Switches syntax-id callback and initialization to `LLSyntaxDefCache`.
indra/newview/app_settings/types_lua_default.xml	Removes Lua types default file (no longer used by the updated code).
indra/llmessage/llcorehttputil.h	Minor whitespace cleanup.
indra/llmessage/llcorehttputil.cpp	Improves LLSD response parsing using `LLSDSerialize::deserialize()`.
doc/external-editor-json-rpc.md	Updates/extends protocol documentation for new syntax-cache APIs and clarifications.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

    else
    {
-        LL_DEBUGS("SyntaxLSL") << "LSLSyntaxId capability URL is empty." << LL_ENDL;
-        loadDefaultKeywordsIntoLLSD();
+        LL_WARNS("SyntaxLSL") << "Malformed syntax defs response, missing 'files' map." << LL_ENDL;
+    }
+
+    result.erase(LLCoreHttpUtil::HttpCoroutineAdapter::HTTP_RESULTS);
+
+    setKeywords(memcached_keywords["lsl_keywords.xml"], memcached_keywords["lua_keywords.xml"]);
+    LLAppViewer::instance()->postToMainCoro(
+        [this]()
+        {
+            mSyntaxIDChangedSignal();
+        });
+}


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

tapple · 2026-04-30T04:55:17Z

    app_settings/std_bump.ini
    app_settings/toolbars.xml
    app_settings/trees.xml
-    app_settings/types_lua_default.xml


I hit this assert when I tried pressing edit again on a script already open in vscode

[2026-04-29 21:50:03] [frame_payload] Payload Bytes:
[0] (147) [1] {"id":1,"jsonrpc":"2.0","result":{"message":"Script already subscribed","script_id":"b9a3098060694bd0dc3b8174bf41f8ad","status":3,"success":false}}

[2026-04-29 21:50:03] [frame_header] Dispatching write containing 1 message(s) containing 2 header bytes and 79 payload bytes
[2026-04-29 21:50:03] [frame_header] Header Bytes:
[0] (2) 81 4F

[2026-04-29 21:50:03] [frame_payload] Payload Bytes:
[0] (79) [1] {"id":2,"jsonrpc":"2.0","result":{"id":"9095b976-6535-080c-f78e-de69f79c1fa9"}}

2026-04-30T04:50:03Z ERROR #LlsdToJson# llcommon/llsdjson.cpp(135) LlsdToJson : Unsupported conversion to JSON from LLSD type (8).

testing on fedora linux. unsure whether I should build viewer with or without DebInfo

I'll run that test case. Thanks for the catch.

I can't reproduce this again

tapple · 2026-04-30T23:17:04Z

+| `slua_definitions.yaml`          | Luau language definitions in YAML format |
+| `slua_keywords.xml`              | Luau keyword definitions in LLSD XML format |
+| `slua_keywords_pretty.xml`       | Luau keyword definitions in formatted LLSD XML format |
+| `slua_selene.yml`                | Luau Selene linter configuration in YAML format |


all these file have been renamed since the last simulator build:

https://github.com/secondlife/lsl-definitions/tree/main/generated

secondlife/lsl-definitions@08bcadd

That can be fixed in a different PR though. no need to block this on a simulator rebuild

Rider-Linden added 2 commits April 28, 2026 10:23

Refactor the LLSyntaxIDLSL/Lua into single LLSyntaxDefCache, use new …

364ff6e

…cap when available to retrieve all language definition files and cache them locally. Retrieve the default definition files from the LSL definitions precompiled library.

Added support to jsonrpc server for the viewer based syntax cache.

84e806f

Rider-Linden requested review from akleshchev, Copilot and marchcat April 29, 2026 21:47

github-actions Bot added c/cpp python llmessage labels Apr 29, 2026

Copilot started reviewing on behalf of Rider-Linden April 29, 2026 21:47 View session

Rider-Linden mentioned this pull request Apr 29, 2026

Retrieve pregenerated tool config files from cache on viewer. secondlife/sl-vscode-plugin#66

Merged

Copilot AI reviewed Apr 29, 2026

View reviewed changes

akleshchev requested a review from maxim-productengine April 29, 2026 21:57

Apply suggestions from code review

89a5681

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of Rider-Linden April 29, 2026 22:12 View session

Copilot finished work on behalf of Rider-Linden April 29, 2026 22:15

Rider-Linden requested a review from Copilot April 29, 2026 22:23

Copilot started reviewing on behalf of Rider-Linden April 29, 2026 22:24 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

trigger the pre-commit.

0f8be80

Rider-Linden force-pushed the rider/defs_cap branch from aea98c5 to 0f8be80 Compare April 29, 2026 22:29

Rider-Linden and others added 3 commits April 29, 2026 15:36

Apply suggestions from code review

e932b04

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Make caps request alphabetical.

5c3bc09

Forgot to remove a file from the cmake

369cc5b

github-actions Bot added the cmake label Apr 29, 2026

marchcat approved these changes Apr 29, 2026

View reviewed changes

tapple reviewed Apr 30, 2026

View reviewed changes

Rider-Linden changed the title ~~Rider/defs cap~~ Get pregenerated config files from the simulator cap and make them available through the websocket. Apr 30, 2026

tapple reviewed Apr 30, 2026

View reviewed changes

tapple mentioned this pull request Apr 30, 2026

[Linux] Assertion fail on LLMeshSkinInfo::updateHash #5748

Open

akleshchev approved these changes May 2, 2026

View reviewed changes

maxim-productengine approved these changes May 3, 2026

View reviewed changes

Conversation

Rider-Linden commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Additional Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Rider-Linden Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tapple Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tapple Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rider-Linden Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

tapple Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

tapple Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Rider-Linden commented Apr 29, 2026 •

edited

Loading

github-actions Bot commented Apr 29, 2026 •

edited

Loading

tapple Apr 30, 2026 •

edited

Loading

tapple Apr 30, 2026 •

edited

Loading

tapple Apr 30, 2026 •

edited

Loading