#3430 Fix incorectly stated permissions for scripts.#5822
Conversation
There was a problem hiding this comment.
Pull request overview
Updates user-facing script editor permission messages to correctly reflect that “no copy” or “no modify” prevents viewing/editing, and removes the incorrect implication that “full permissions” (including transfer) are required.
Changes:
- Updated the script editor panel “can_not_view” message to mention both “no copy” and “no modify”.
- Updated the live LSL editor floater “not_allowed” message similarly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| indra/newview/skins/default/xui/en/panel_script_ed.xml | Corrects the English script editor panel denial message to include “no modify” and remove “full permissions” wording. |
| indra/newview/skins/default/xui/en/floater_live_lsleditor.xml | Corrects the English live script editor denial message to include “no modify” and remove “full permissions” wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <panel.string | ||
| name="can_not_view"> | ||
| You can not view or edit this script, since it has been set as "no copy". You need full permissions to view or edit a script inside an object. | ||
| You can not view or edit this script, since it has been set as "no copy" or "no modify". You need these permissions to view or edit a script inside an object. | ||
| </panel.string> |
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Applied in commit a13b5dd: updated localized panel_script_ed.xml and floater_live_lsleditor.xml strings across non-English locales to include no-copy/no-modify and remove full-permissions wording. Screenshot (updated UI text preview): /tmp/script-permission-localization-update.png.
| <floater.string | ||
| name="not_allowed"> | ||
| You can not view or edit this script, since it has been set as "no copy". You need full permissions to view or edit a script inside an object. | ||
| You can not view or edit this script, since it has been set as "no copy" or "no modify". You need these permissions to view or edit a script inside an object. | ||
| </floater.string> |
Agent-Logs-Url: https://github.com/secondlife/viewer/sessions/fa54f36b-fa47-43cf-9172-e882e3703b8a Co-authored-by: akleshchev <117672381+akleshchev@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
'no copy' or 'no modify' permissions block the ability to edit. 'no transfer' is editable so full permission isn't required.