Skip to content

#3430 Fix incorectly stated permissions for scripts.#5822

Merged
akleshchev merged 2 commits into
developfrom
andreyk/viewer_3430
May 15, 2026
Merged

#3430 Fix incorectly stated permissions for scripts.#5822
akleshchev merged 2 commits into
developfrom
andreyk/viewer_3430

Conversation

@akleshchev
Copy link
Copy Markdown
Contributor

'no copy' or 'no modify' permissions block the ability to edit. 'no transfer' is editable so full permission isn't required.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates user-facing script editor permission messages to correctly reflect that “no copy” or “no modify” prevents viewing/editing, and removes the incorrect implication that “full permissions” (including transfer) are required.

Changes:

  • Updated the script editor panel “can_not_view” message to mention both “no copy” and “no modify”.
  • Updated the live LSL editor floater “not_allowed” message similarly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
indra/newview/skins/default/xui/en/panel_script_ed.xml Corrects the English script editor panel denial message to include “no modify” and remove “full permissions” wording.
indra/newview/skins/default/xui/en/floater_live_lsleditor.xml Corrects the English live script editor denial message to include “no modify” and remove “full permissions” wording.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 15 to 18
<panel.string
name="can_not_view">
You can not view or edit this script, since it has been set as &quot;no copy&quot;. You need full permissions to view or edit a script inside an object.
You can not view or edit this script, since it has been set as &quot;no copy&quot; or &quot;no modify&quot;. You need these permissions to view or edit a script inside an object.
</panel.string>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in commit a13b5dd: updated localized panel_script_ed.xml and floater_live_lsleditor.xml strings across non-English locales to include no-copy/no-modify and remove full-permissions wording. Screenshot (updated UI text preview): /tmp/script-permission-localization-update.png.

Comment on lines 16 to 19
<floater.string
name="not_allowed">
You can not view or edit this script, since it has been set as &quot;no copy&quot;. You need full permissions to view or edit a script inside an object.
You can not view or edit this script, since it has been set as &quot;no copy&quot; or &quot;no modify&quot;. You need these permissions to view or edit a script inside an object.
</floater.string>
Agent-Logs-Url: https://github.com/secondlife/viewer/sessions/fa54f36b-fa47-43cf-9172-e882e3703b8a

Co-authored-by: akleshchev <117672381+akleshchev@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5814 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.21O23l --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9194970296386012296,7899523978908838449,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15018741204913447265,13277292688785360037,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium chromium --headless --no-sandbox --disable-gpu --screenshot=/tmp/script-permission-localization-update.png --window-size=1400,700 file:///tmp/script-permission-localization-update.html git (dns block)
  • clients2.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5814 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.21O23l --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9194970296386012296,7899523978908838449,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15018741204913447265,13277292688785360037,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium chromium --headless --no-sandbox --disable-gpu --screenshot=/tmp/script-permission-localization-update.png --window-size=1400,700 file:///tmp/script-permission-localization-update.html git (dns block)
  • redirector.gvt1.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5814 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.21O23l --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9194970296386012296,7899523978908838449,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15018741204913447265,13277292688785360037,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium chromium --headless --no-sandbox --disable-gpu --screenshot=/tmp/script-permission-localization-update.png --window-size=1400,700 file:///tmp/script-permission-localization-update.html git (dns block)
  • www.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5814 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.21O23l --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9194970296386012296,7899523978908838449,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15018741204913447265,13277292688785360037,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium chromium --headless --no-sandbox --disable-gpu --screenshot=/tmp/script-permission-localization-update.png --window-size=1400,700 file:///tmp/script-permission-localization-update.html git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@github-actions
Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (akleshchev)[https://github.com/akleshchev]
❌ @Copilot
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@akleshchev akleshchev merged commit 4cf0f55 into develop May 15, 2026
7 of 15 checks passed
@akleshchev akleshchev deleted the andreyk/viewer_3430 branch May 15, 2026 18:58
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
@akleshchev akleshchev linked an issue May 15, 2026 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect error message on viewing limited permissions script

4 participants