#5818 Fix setCursor crash#5832
Merged
Merged
Conversation
reshape tried to setCursor before postBuild
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the profile pick panel caused by reshape() attempting to call setCursor() on an uninitialized LLLineEditor* before postBuild() assigns child pointers.
Changes:
- Initialize
LLPanelProfilePickchild-control pointers tonullptrin the header to avoid indeterminate values prior topostBuild(). - Guard
mPickLocation->setCursor(0)inLLPanelProfilePick::reshape()to avoid dereferencing a null pointer whenreshape()runs early. - Minor cleanup in
LLLineEditor::setCursor()to reuse theLLWStringreference instead of callinggetWString()repeatedly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| indra/newview/llpanelprofilepicks.h | Default-initialize UI child pointers to nullptr so early lifecycle calls don’t see garbage values. |
| indra/newview/llpanelprofilepicks.cpp | Add a null check in reshape() before using mPickLocation, preventing the reported crash. |
| indra/llui/lllineeditor.cpp | Reduce repeated getWString() calls by caching a const LLWString& during cursor/scroll calculations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maxim-productengine
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reshape() tried to setCursor(0) before postBuild()