🐛 Input Handlers were being ignored on first invoke#38
Merged
Kerrick merged 3 commits intosecondstreet:masterfrom Oct 10, 2017
Merged
Conversation
Contributor
|
It's probably a good idea not to encourage people to pass in Then, you can call those from the ember-material-components-web/addon/components/mdc-textfield.js Lines 242 to 244 in bf27d26 |
Added `onfocus`, `onblur`, `onkeydown`, and `oninput` event handlers for the `mdc-textfield`.
Kerrick
approved these changes
Oct 10, 2017
Contributor
|
Thank you so much for the PR! This will ship out with v0.0.37 👍 |
Kerrick
added a commit
that referenced
this pull request
Oct 19, 2017
- 🐛 {{mdc-tab}} indicator fixes (#31)
- 🔧 Use unminified js/css in non-prod environments (#46)
- 📝 Add contributor gallery to README (#40)
- ✨ Implement {{mdc-layout-grid}} (#42)
- ✨ Implement {{mdc-grid-list}} (#43)
- 🐛 📝 Fix toolbar bug, add toolbar docs. (#37)
- 💡 📝 Update documentation to use ember-freestyle (#44)
- 🐛 {{mdc-textfield}}'s placeholder and value no longer overlap (#41)
- 💥 {{mdc-card}}'s children now yield their own children (#39)
- ✨ {{mdc-textfield}} exposes event handlers (#38)
- ✨ {{mdc-list}} now yields text and secondary text (#36)
- 📝 Create CODE_OF_CONDUCT.md (#35)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Feature
What will it allow you to do that you can't do today? Tie action handlers to input event listeners
Why do you need this feature and how will it benefit other users? The only method to registering input event listeners is to pass
inputKeydownHandlersdirectly, but that's something that's supposed to be private and interface with the MDC Foundation class.Are there any drawbacks to this feature? No, this mirrors the way other inputs handle registering event listeners.
Found a bug (this is outdated, but was the source of the new feature)
Which version of the project did you use when you noticed the bug? 0.0.36
How do you reproduce the error condition?
What happened that you think is a bug? The action handler was not invoked on first keypress
What should it do instead? The action handler should be invoked on input event
PR details
Did you confirm this fix/feature is something that is needed? Yes
Did you write automated tests? Nope, since there are not any real tests currently written
Did you add documentation for the changes you made? Yes, updated the
application.hbsto detail that someone can register event handlers to the text-field.In lieu of a style guide, did you match your code style to the rest of the project? Yes