This repository was archived by the owner on May 10, 2022. It is now read-only.
update Id and label in Section purger annotation #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niccolox
approved these changes
May 30, 2019
niccolox
left a comment
niccolox
left a comment
There was a problem hiding this comment.
does this need to go deeper with function names etc?
Contributor
Author
|
do you have anything in mind in particular @niccolox ? |
|
no, open question, probably won't become an issue. Highly unlikely 2 CDNs will be running on a single app. |
Contributor
Author
|
This fix will make everything work properly even in the event of multiple CDNs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid potential naming conflicts with other purgers. Fixes #3