Tonight's autonomous code-quality pass on the new TNC + HARQ work, informed by Codex review (full notes /tmp/codex_quality_findings.md, 22 ranked findings). Tackled the safe ones with high impact: Safety / correctness (#3, #7-#8, #14): - ultra_tnc: skip config loading on --help / --list-audio-devices so a malformed config doesn't break operator recovery - tnc_session: cmdStats() now null-guards cmd_emit_, matching the rest of the emit path (was the one place that could throw std::bad_function_call on a null callback) - tnc_bridge: postPTT() callbacks no longer fire under ptt_mutex_. Computes the PTT transition under the lock, releases, then invokes sink + hardware callback. Closes a deadlock window when a slow hardware-PTT serial write blocks under the mutex. - (#7 PTT setLine() return-check deferred — needs decision on whether to fail-startup or fall-back-to-VOX. Punted to follow-up.) Tests (#12, #19-#20): - 1 new test_tnc_session: corrupt-deflate RX silently dropped (regression guard for the marker-strip path) - 6 new test_soft_combine cases: * setEnabled(false) clears retained entries * Zero sender_hash is a no-op (don't pollute future sessions) * setMaxEntries(0) disables retention * Empty-LLR retain is a no-op * Saturation: pin to exact implementation cap (60.0) on both + and - sides instead of just "<= 100" Docs / comments (#18, #22): - soft_combine.hpp: comment on carrier_count_hash now matches what the hash actually contains (was claiming pilot-spacing coverage we don't actually do) - PAT_VARA_AUDIT.md: trailing-whitespace cleanup Local ctest 34/34. Test counts: SoftCombine 10→16, TNCSession 98→100, TNCBridge 17→23. Net +14 tests. Deferred (need broader judgment, not autonomous-safe): - #2 extract config helpers to testable target (refactor) - #5 explicit negative CLI flags (interface design) - #9 sink ownership lifetime race (concurrency design) - #11 BUFFER 0 immediacy vs rate-limit (protocol judgment) - #13 flushDataTxBuffer extraction for testability - #15 sendBinary error propagation (interface change) - #16 HARQ key construction extraction - #17 HARQ when CW0 fails (architectural) - #21 UltraTNCStation threading model Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-Authored-By: Codex (review) <noreply@openai.com>

Winlink #2

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions