Merged
Conversation
secup
added a commit
that referenced
this pull request
May 3, 2026
…x review Codex review #6: inject_channel_type was stored from CLI/config but never dispatched. Only AWGN was applied. The previous behavior silently used AWGN for any type spelling, which was confusing — a user setting `inject_channel_type = watterson` would expect Watterson fading and silently get AWGN. Reject anything other than `awgn` loudly at parse time, in both config-file and CLI paths. Help text updated to make the constraint explicit. Other channel types remain implementable later if/when we wire them through. Also archive the full Codex quality review at docs/CODEX_QUALITY_REVIEW_2026-05-03.md so the deferred items (threading, sendBinary error propagation, HARQ-key extraction, explicit-negative CLI flags, etc.) are tracked in repo history rather than only in /tmp. Local ctest 34/34. Manual verify: $ ultra_tnc --inject-channel watterson ultra_tnc --inject-channel only supports awgn; got 'watterson' $ ultra_tnc --inject-channel awgn # accepted Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated agent task completed after manual supervision because the watchdog was paused during toolchain verification.
Task: agents/queue/claude/002-agent-pr-template.md
Branch: agent/20260430_152801-002-agent-pr-template
Local gate: passed, report agents/reports/local_20260430_153751
Required Review