Skip to content

ICCRedirectionCreator: Handle cases with implicit intents #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

ICCRedirectionCreator: Handle cases with implicit intents #826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions soot-infoflow-android/src/soot/jimple/infoflow/android/iccta/IccRedirectionCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,21 +194,27 @@ protected SootMethod generateRedirectMethodForStartActivityForResult(SootClass o
Local intentParameterLocal = lg.generateLocal(INTENT_TYPE);
b.getUnits().add(Jimple.v().newIdentityStmt(intentParameterLocal, Jimple.v().newParameterRef(INTENT_TYPE, 1)));

Value arIntentLocal;
// call onCreate
Local componentLocal = lg.generateLocal(destComp.getType());
{
SootMethod targetDummyMain = componentToEntryPoint.getEntryPoint(destComp);
if (targetDummyMain == null)
throw new RuntimeException(
String.format("Destination component %s has no dummy main method", destComp.getName()));
b.getUnits().add(Jimple.v().newAssignStmt(componentLocal, Jimple.v()
.newStaticInvokeExpr(targetDummyMain.makeRef(), Collections.singletonList(intentParameterLocal))));
}
if (destComp != null) {
Local componentLocal = lg.generateLocal(destComp.getType());
{
SootMethod targetDummyMain = componentToEntryPoint.getEntryPoint(destComp);
if (targetDummyMain == null)
throw new RuntimeException(
String.format("Destination component %s has no dummy main method", destComp.getName()));
b.getUnits().add(Jimple.v().newAssignStmt(componentLocal, Jimple.v().newStaticInvokeExpr(
targetDummyMain.makeRef(), Collections.singletonList(intentParameterLocal))));
}

// Get the activity result
Local arIntentLocal = lg.generateLocal(INTENT_TYPE);
b.getUnits().add(Jimple.v().newAssignStmt(arIntentLocal, Jimple.v().newInterfaceInvokeExpr(componentLocal,
componentToEntryPoint.getComponentExchangeInfo().getResultIntentMethod.makeRef())));
// Get the activity result
arIntentLocal = lg.generateLocal(INTENT_TYPE);
b.getUnits().add(Jimple.v().newAssignStmt(arIntentLocal, Jimple.v().newInterfaceInvokeExpr(componentLocal,
componentToEntryPoint.getComponentExchangeInfo().getResultIntentMethod.makeRef())));
} else {
//Nonetheless, we want to have onActivityResult in the call graph.
arIntentLocal = NullConstant.v();
}

// some apps do not have an onActivityResult method even they use
// startActivityForResult to communicate with other components.
Expand Down