fix caching of llvm::ModuleSlotTracker instances #424
Merged
pdschubert merged 2 commits intodevelopmentfrom Oct 1, 2021
Merged
fix caching of llvm::ModuleSlotTracker instances #424pdschubert merged 2 commits intodevelopmentfrom
pdschubert merged 2 commits intodevelopmentfrom
Conversation
…alue - make sure that destruction of an llvm::Module leads to destruction of its llvm::ModuleSlotTracker in cache
fabianbs96
reviewed
Sep 27, 2021
Member
fabianbs96
left a comment
fabianbs96
left a comment
There was a problem hiding this comment.
Looks good to me; only a few minor things thay you might change
| llvm::ModuleSlotTracker & | ||
| ModulesToSlotTracker::getSlotTrackerForModule(const llvm::Module *M) { | ||
| auto &ret = MToST[M]; | ||
| if (M == nullptr && ret == nullptr) { |
Member
There was a problem hiding this comment.
Consider adding an assertion to prevent returning nullptr if M != nullptr && ret == nullptr
Member
Author
There was a problem hiding this comment.
yeah that might ease debugging in case it happens. However, if we return nullptr we will get a crash anyway.
vulder
reviewed
Sep 28, 2021
vulder
approved these changes
Sep 28, 2021
Collaborator
vulder
left a comment
vulder
left a comment
There was a problem hiding this comment.
except for the open conversations, this LGTM
fabianbs96
approved these changes
Sep 28, 2021
pdschubert
approved these changes
Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... for printing llvm::Value - make sure that destruction of an llvm::Module leads to destruction of its llvm::ModuleSlotTracker in cache
please merge #423 first.